[
https://issues.apache.org/jira/browse/OODT-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248122#comment-13248122
]
[email protected] commented on OODT-438:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4665/#review6733
-----------------------------------------------------------
Ship it!
LGTM!
- Chris
On 2012-04-06 02:26:01, brian Foster wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4665/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-06 02:26:01)
bq.
bq.
bq. Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and
Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Also includes minor changes to spring file properties and a getter method
i added to MoveFile CrawlerAction for a unit-test in CAS-PGE
bq.
bq.
bq. This addresses bug OODT-438.
bq. https://issues.apache.org/jira/browse/OODT-438
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/MoveFile.java
1310151
bq.
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigReader.java
1310151
bq. trunk/crawler/src/main/resources/action-beans.xml 1310151
bq. trunk/crawler/src/main/resources/precondition-beans.xml 1310151
bq.
bq. Diff: https://reviews.apache.org/r/4665/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. need to add unit-test... however, current cas-pge patch for change to use
AutoDetectProductCrawler has a unit-test which verifies this works
bq.
bq.
bq. Thanks,
bq.
bq. brian
bq.
bq.
> Make CAS-Crawlers MimeExtractorConfigReader relative file paths be relative
> to its XML file
> -------------------------------------------------------------------------------------------
>
> Key: OODT-438
> URL: https://issues.apache.org/jira/browse/OODT-438
> Project: OODT
> Issue Type: Improvement
> Components: crawler
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-438.2012-04-05.patch.txt
>
>
> mime-types.xml and extractor config files, when specifying a relative path
> should be relative to the mime-extractor-map.xml file which they are
> specified in... allows the files to exist in the same directory and be moved
> around without requiring file updates to mime-extractor-map.xml... if these
> files can still be put in different directories and pointed at via absolute
> paths
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
