[
https://issues.apache.org/jira/browse/OODT-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279606#comment-13279606
]
Ross Laidlaw edited comment on OODT-452 at 5/19/12 9:09 PM:
------------------------------------------------------------
Hi Chris!
Apologies! After reading your comment, I realised that I had made a mistake
when testing the build after moving the files. And indeed some unit tests for
the filemgr component are failing with the build:
* org.apache.oodt.cas.filemgr.catalog.TestLuceneCatalog
* org.apache.oodt.cas.filemgr.ingest.TestLocalCache
* org.apache.oodt.cas.filemgr.ingest.TestStdIngester
* org.apache.oodt.cas.filemgr.ingest.TestRmiCache
* org.apache.oodt.cas.filemgr.tools.TestMetadataBasedProductMover
* org.apache.oodt.cas.filemgr.ingest.TestCachedIngester
So there's a bit more work to be done other than just moving the files over. I
found that each test is failing because of the following code (same in each
test class):
{code}
System.setProperty("org.apache.oodt.cas.filemgr.validation.dirs",
"file://" + new File("./src/main/resources/examples").getAbsolutePath());
{code}
And if I change the above code to the following, the tests all pass and the
build succeeds:
{code}
System.setProperty("org.apache.oodt.cas.filemgr.validation.dirs",
"file://" + new
File("./src/main/resources/examples/core").getAbsolutePath());
{code}
Would you be happy for me to commit the moves and also patch the tests? I'll
upload the patch soon after posting this comment.
was (Author: rlaidlaw):
Hi Chris!
Apologies! After reading your comment, I realised that I had not tested the
build after moving the files. And indeed some unit tests for the filemgr
component are failing with the build:
* org.apache.oodt.cas.filemgr.catalog.TestLuceneCatalog
* org.apache.oodt.cas.filemgr.ingest.TestLocalCache
* org.apache.oodt.cas.filemgr.ingest.TestStdIngester
* org.apache.oodt.cas.filemgr.ingest.TestRmiCache
* org.apache.oodt.cas.filemgr.tools.TestMetadataBasedProductMover
* org.apache.oodt.cas.filemgr.ingest.TestCachedIngester
So there's a bit more work to be done other than just moving the files over. I
found that each test is failing because of the following code (same in each
test class):
{code}
System.setProperty("org.apache.oodt.cas.filemgr.validation.dirs",
"file://" + new File("./src/main/resources/examples").getAbsolutePath());
{code}
And if I change the above code to the following, the tests all pass and the
build succeeds:
{code}
System.setProperty("org.apache.oodt.cas.filemgr.validation.dirs",
"file://" + new
File("./src/main/resources/examples/core").getAbsolutePath());
{code}
Would you be happy for me to commit the moves and also patch the tests? I'll
upload the patch soon after posting this comment.
> Move the default File Manager policy files to 'core' subdirectory
> -----------------------------------------------------------------
>
> Key: OODT-452
> URL: https://issues.apache.org/jira/browse/OODT-452
> Project: OODT
> Issue Type: Sub-task
> Components: file manager
> Reporter: Ross Laidlaw
> Labels: gsoc2012
> Fix For: 0.5
>
> Attachments: OODT-452.rlaidlaw.2012-05-19.patch.txt
>
>
> Move the current contents of
> http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples,
> i.e. the default File Manager policy files 'elements.xml',
> 'product-types.xml' and 'product-type-element-map.xml' to a subdirectory
> named 'core', i.e.:
> http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples/core.
> (ensure assembly.xml, unit tests, etc still work after moving!)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
