[
https://issues.apache.org/jira/browse/OODT-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677749#comment-13677749
]
Chris A. Mattmann commented on OODT-618:
----------------------------------------
Great, initial work Rajith!
Some initial comments:
1. Consider looking at o.a.oodt.commons.xml.XMLUtils -- has a lot of methods to
help out in parsing names.
2. Consider defining an interface with static final Strings to contain the
names like e.g.,
{code:java}
public interface GangliaMetKeys{
public static final String HOST = "HOST";
//...
}
{code}
3. Consider writing a few unit tests and providing a sample Ganglia XML file as
a test resource, and then showing your parsing utilities work.
I'd say 1 is an important one; 2 is probably optional; and 3 is an important
one too before committing.
Thanks!
> Implement ganglia XML parser
> ----------------------------
>
> Key: OODT-618
> URL: https://issues.apache.org/jira/browse/OODT-618
> Project: OODT
> Issue Type: Sub-task
> Components: resource manager
> Reporter: Rajith Siriwardana
> Assignee: Rajith Siriwardana
> Fix For: 0.6
>
> Attachments: OODT-618 Implement ganglia XML parser.patch
>
>
> This will consists with Ganglia XML reader and ganglia metric builder. The
> received XML will be parsed and it will creates a node which is a tree
> structure and also a java list consisting the stats of the Resource Nodes by
> holding ganglia metrics. which can be queried as preferred.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira