[ 
https://issues.apache.org/jira/browse/OODT-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702048#comment-13702048
 ] 

Chris A. Mattmann commented on OODT-559:
----------------------------------------

Reverted per:

{noformat}
[chipotle:~/tmp/apache-oodt-0.6/commons] mattmann% svn diff -r1490878:1490877 .
Index: src/main/java/org/apache/oodt/commons/date/DateUtils.java
===================================================================
--- src/main/java/org/apache/oodt/commons/date/DateUtils.java   (revision 
1490878)
+++ src/main/java/org/apache/oodt/commons/date/DateUtils.java   (revision 
1490877)
@@ -206,7 +206,7 @@
     }
     
     public static long getTimeInMillis(Calendar cal, Calendar epoch) throws 
Exception {
-        long epochDiffInMilli = epoch.getTimeInMillis() - 
(julianEpoch.getTimeInMillis()+julianEpoch.getTimeZone().getOffset(julianEpoch.getTimeInMillis()))
 ;
+        long epochDiffInMilli = epoch.getTimeInMillis() - 
julianEpoch.getTimeInMillis() ;
         if (cal.getTimeZone().getID().equals("TAI"))
             epochDiffInMilli += getLeapSecsForDate(epoch) * 1000;
         long milliseconds = cal.getTimeInMillis();
[chipotle:~/tmp/apache-oodt-0.6/commons] mattmann% svn diff -r1490878:1490877 . 
> revert.patch
[chipotle:~/tmp/apache-oodt-0.6/commons] mattmann% patch -p0 < ./revert.patch 
patching file src/main/java/org/apache/oodt/commons/date/DateUtils.java
{noformat}

                
> Unit test failure in testDoDynamicReplacement for "Europe/London" timezone
> --------------------------------------------------------------------------
>
>                 Key: OODT-559
>                 URL: https://issues.apache.org/jira/browse/OODT-559
>             Project: OODT
>          Issue Type: Bug
>          Components: commons
>    Affects Versions: 0.6
>            Reporter: Varun Ratnakar
>            Assignee: Chris A. Mattmann
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: fix_date_test.patch
>
>
> I've been regularly encountering a unit test failure in 
> testDoDynamicReplacement. After investigating it a bit further, I found that 
> it seems to be related to the TimeZone. If I set my computer's timezone to 
> PST (or any other timezone except "Europe/London"), it works, but with 
> "Europe/London" Timezone I get the following:
> DATE_TO_SECS (2008-01-20T16:30:28.000-000033  , TAI_FORMAT , 1993-01-01)
>                       = 474996601.000
> Should be             = 475000201.000
> Difference of 3600 seconds = 1 hour

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to