[
https://issues.apache.org/jira/browse/OODT-562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793690#comment-13793690
]
Chris A. Mattmann commented on OODT-562:
----------------------------------------
Hey Varun, thanks, a few comments:
1. In the patch anywhere in the curation service that adds something should IMO
be using PUT or POST; and anything that removes something should be using
DELETE. The GET methods look OK.
2. Public new methods at the bottom of the patch should have javadoc, or should
be considered helper package protected functions or private ones.
Feel free to use http://review.apache.org/ (Review Board) for the next patch
review for inline commenting. Thanks!
> Parent and Element editing for Product Types
> --------------------------------------------
>
> Key: OODT-562
> URL: https://issues.apache.org/jira/browse/OODT-562
> Project: OODT
> Issue Type: Sub-task
> Components: file manager
> Affects Versions: 0.6
> Reporter: Varun Ratnakar
> Priority: Minor
> Labels: api-addition
> Fix For: 0.7
>
> Attachments: OODT-562.varunratnakar.021213.patch.txt,
> OODT-562.varunratnakar.101213.patch.txt
>
>
> File Manager API Additions: (XmlRpcFileManager , XmlRpcFileManagerClient)
> * addParentForProductType - to support parent additions to data types in
> Wings Data Catalog
> * removeParentForProductType
> removeProductType
> * addElementsForProductType - to support property additions to data types in
> Wings Data Catalog
> * removeElementsForProductType
> Validation Layer Changes: (To support the above API additions)
> * addParentForProductType - invocation from API function above
> * removeParentForProductType - invocation from API function above
> Note: The attached patch only provides ValidationLayer implementations of the
> above functions for XmlValidationLayer, whereas only stub functions exist for
> DataSourceValidationLayer and ScienceDataValidationLayer.
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
