[
https://issues.apache.org/jira/browse/OODT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087215#comment-14087215
]
Ross Laidlaw edited comment on OODT-737 at 8/6/14 7:05 AM:
-----------------------------------------------------------
These patches fix the tests in the 'cli' package. The tests originally
referenced resources in 'src/main' and the version of cmd-line-options.xml in
src/main was missing the following typeName definition (i.e. this was present
in src/test/resources/cmd-line-options.xml but not in
src/main/resources/cmd-line-options.xml):
{code:xml}
<bean id="typeName"
class="org.apache.oodt.cas.cli.option.AdvancedCmdLineOption">
<property name="shortOption" value="tn" />
<property name="longOption" value="typeName" />
<property name="description" value="ProductType name" />
<property name="hasArgs" value="true" />
<property name="argsDescription" value="product-type-name" />
<property name="requirementRules">
<list>
<bean class="org.apache.oodt.cas.cli.option.require.ActionDependencyRule"
p:actionName="addProductType" p:relation="REQUIRED" />
</list>
</property>
<property name="handler">
<bean class="org.apache.oodt.cas.cli.option.handler.ApplyToActionHandler">
<property name="applyToActions">
<list>
<bean class="org.apache.oodt.cas.cli.option.handler.ApplyToAction"
p:actionName="addProductType"
p:methodName="setProductTypeName"/>
</list>
</property>
</bean>
</property>
</bean>
{code}
With the second patch I've made sure both copies of cmd-line-options.xml (in
src/main/resources and src/test/resources) are identical and have the typeName
definition.
{noformat}
Results :
Tests run: 21, Failures: 0, Errors: 0, Skipped: 0
{noformat}
I've committed the patches in r1616087 and r1616113.
was (Author: rlaidlaw):
These patches fix the tests in the 'cli' package. The tests originally
referenced resources in 'src/main' and the version of cmd-line-options.xml in
src/main was missing the following additional XML code (i.e. present in
src/test/resources/cmd-line-options.xml):
{code:xml}
<bean id="typeName"
class="org.apache.oodt.cas.cli.option.AdvancedCmdLineOption">
<property name="shortOption" value="tn" />
<property name="longOption" value="typeName" />
<property name="description" value="ProductType name" />
<property name="hasArgs" value="true" />
<property name="argsDescription" value="product-type-name" />
<property name="requirementRules">
<list>
<bean class="org.apache.oodt.cas.cli.option.require.ActionDependencyRule"
p:actionName="addProductType" p:relation="REQUIRED" />
</list>
</property>
<property name="handler">
<bean class="org.apache.oodt.cas.cli.option.handler.ApplyToActionHandler">
<property name="applyToActions">
<list>
<bean class="org.apache.oodt.cas.cli.option.handler.ApplyToAction"
p:actionName="addProductType"
p:methodName="setProductTypeName"/>
</list>
</property>
</bean>
</property>
</bean>
{code}
With the second patch I've made sure both copies of cmd-line-options.xml (in
src/main/resources and src/test/resources) are identical and have the typeName
definition.
{noformat}
Results :
Tests run: 21, Failures: 0, Errors: 0, Skipped: 0
{noformat}
I've committed the patches in r1616087 and r1616113.
> Fix File Manager Unit Tests - 'cli' Package
> -------------------------------------------
>
> Key: OODT-737
> URL: https://issues.apache.org/jira/browse/OODT-737
> Project: OODT
> Issue Type: Sub-task
> Components: file manager
> Affects Versions: 0.7
> Reporter: Ross Laidlaw
> Assignee: Ross Laidlaw
> Labels: patch, test
> Fix For: 0.7
>
> Attachments: OODT-737.cmd-line-options.rlaidlaw.2014-08-05.patch.txt,
> OODT-737.fix-cli-tests.rlaidlaw.2014-08-05.patch.txt
>
>
> There are 21 failing tests from the 'cli' package that need to be repaired.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
