OODT-890 make class static
Project: http://git-wip-us.apache.org/repos/asf/oodt/repo Commit: http://git-wip-us.apache.org/repos/asf/oodt/commit/fae02f97 Tree: http://git-wip-us.apache.org/repos/asf/oodt/tree/fae02f97 Diff: http://git-wip-us.apache.org/repos/asf/oodt/diff/fae02f97 Branch: refs/heads/master Commit: fae02f97dc4ef06768b60535da675ca135ab5dd6 Parents: 733436e Author: Tom Barber <[email protected]> Authored: Mon Oct 26 23:04:47 2015 +0000 Committer: Tom Barber <[email protected]> Committed: Mon Oct 26 23:04:47 2015 +0000 ---------------------------------------------------------------------- .../oodt/cas/filemgr/browser/model/CasDB.java | 2 +- .../catalog/mapping/DataSourceIngestMapper.java | 52 ++++++++++---------- .../repository/SerializedCatalogRepository.java | 8 +-- .../XmlRpcCommunicationChannelServer.java | 2 +- .../struct/impl/index/DataSourceIndex.java | 52 ++++++++++---------- .../index/WorkflowManagerDataSourceIndex.java | 30 +++++------ .../system/impl/CatalogServiceLocal.java | 6 +-- .../cas/catalog/util/PluginClassLoader.java | 4 +- .../org/apache/oodt/commons/MultiServer.java | 2 +- .../commons/activity/SQLDatabaseRetrieval.java | 2 +- .../apache/oodt/commons/exec/EnvUtilities.java | 6 +-- .../apache/oodt/commons/exec/ExecHelper.java | 6 +-- .../commons/object/jndi/ObjectNameParser.java | 2 +- .../commons/activity/CompositeActivityTest.java | 36 +++++++------- .../DatagramLoggingActivityFactoryTest.java | 2 +- .../oodt/commons/activity/HistoryTest.java | 2 +- .../commons/io/FixedBufferOutputStreamTest.java | 16 +++--- .../commons/object/jndi/ObjectContextTest.java | 10 ++-- .../commons/object/jndi/TestContextTest.java | 6 +-- .../cas/filemgr/catalog/solr/SolrClient.java | 2 +- .../datatransfer/RemoteDataTransferer.java | 2 +- .../filemgr/datatransfer/S3DataTransferer.java | 4 +- .../oodt/cas/filemgr/ingest/RmiCache.java | 8 +-- .../java/org/apache/oodt/profile/Profile.java | 2 +- .../apache/oodt/profile/ProfileAttributes.java | 2 +- .../org/apache/oodt/profile/ProfileElement.java | 2 +- .../apache/oodt/profile/ResourceAttributes.java | 2 +- .../profile/EnumeratedProfileElementTest.java | 2 +- .../oodt/profile/ResourceAttributesTest.java | 2 +- .../action/CrossProtocolTransferCliAction.java | 2 +- .../protocol/verify/BasicProtocolVerifier.java | 2 +- .../protocol/auth/TestBasicAuthentication.java | 6 +-- .../oodt/cas/protocol/http/TestHttpFile.java | 4 +- .../oodt/cas/protocol/imaps/ImapsProtocol.java | 8 +-- .../cas/protocol/imaps/TestImapsProtocol.java | 2 +- .../cas/protocol/sftp/TestJschSftpProtocol.java | 4 +- .../sftp/UnsupportedShellProcessProvider.java | 6 +-- .../apache/oodt/cas/pushpull/daemon/Daemon.java | 4 +- .../cas/pushpull/daemon/DaemonLauncher.java | 2 +- .../renamingconventions/RenamingConvention.java | 6 +-- .../cas/pushpull/protocol/ProtocolHandler.java | 4 +- .../retrievalsystem/FileRetrievalSystem.java | 12 ++--- .../retrievalsystem/RetrievalSetup.java | 2 +- .../cas/resource/batchmgr/XmlRpcBatchMgr.java | 2 +- .../resource/jobrepo/XStreamJobRepository.java | 6 +-- .../cas/resource/mux/TestQueueMuxBatchmgr.java | 2 +- .../cas/resource/mux/TestQueueMuxMonitor.java | 4 +- .../engine/processor/TaskProcessor.java | 2 +- .../processor/WorkflowProcessorHelper.java | 2 +- .../oodt/cas/workflow/structs/TaskJob.java | 2 +- .../workflow/system/XmlRpcWorkflowManager.java | 2 +- .../xmlps/structs/CDEResultInputStream.java | 2 +- .../oodt/xmlquery/CompressedObjectCodec.java | 4 +- .../oodt/xmlquery/CompressedStringCodec.java | 4 +- .../org/apache/oodt/xmlquery/ObjectCodec.java | 4 +- .../org/apache/oodt/xmlquery/QueryElement.java | 2 +- .../org/apache/oodt/xmlquery/QueryHeader.java | 2 +- .../java/org/apache/oodt/xmlquery/XMLQuery.java | 2 +- .../apache/oodt/xmlquery/CodecFactoryTest.java | 2 +- .../org/apache/oodt/xmlquery/HeaderTest.java | 2 +- .../org/apache/oodt/xmlquery/ResultTest.java | 2 +- 61 files changed, 193 insertions(+), 193 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/app/fmbrowser/src/main/java/org/apache/oodt/cas/filemgr/browser/model/CasDB.java ---------------------------------------------------------------------- diff --git a/app/fmbrowser/src/main/java/org/apache/oodt/cas/filemgr/browser/model/CasDB.java b/app/fmbrowser/src/main/java/org/apache/oodt/cas/filemgr/browser/model/CasDB.java index ca24c4f..5359941 100644 --- a/app/fmbrowser/src/main/java/org/apache/oodt/cas/filemgr/browser/model/CasDB.java +++ b/app/fmbrowser/src/main/java/org/apache/oodt/cas/filemgr/browser/model/CasDB.java @@ -104,7 +104,7 @@ public class CasDB { try { e = client.getElementByName(elementName); elementID = e.getElementId(); - } catch (ValidationLayerException e1) { + } catch (ValidationLayerException ignored) { } return elementID; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/catalog/src/main/java/org/apache/oodt/cas/catalog/mapping/DataSourceIngestMapper.java ---------------------------------------------------------------------- diff --git a/catalog/src/main/java/org/apache/oodt/cas/catalog/mapping/DataSourceIngestMapper.java b/catalog/src/main/java/org/apache/oodt/cas/catalog/mapping/DataSourceIngestMapper.java index 081b6d6..25ea22b 100644 --- a/catalog/src/main/java/org/apache/oodt/cas/catalog/mapping/DataSourceIngestMapper.java +++ b/catalog/src/main/java/org/apache/oodt/cas/catalog/mapping/DataSourceIngestMapper.java @@ -69,10 +69,10 @@ public class DataSourceIngestMapper implements IngestMapper { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -91,10 +91,10 @@ public class DataSourceIngestMapper implements IngestMapper { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -113,10 +113,10 @@ public class DataSourceIngestMapper implements IngestMapper { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -140,13 +140,13 @@ public class DataSourceIngestMapper implements IngestMapper { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -170,13 +170,13 @@ public class DataSourceIngestMapper implements IngestMapper { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -201,13 +201,13 @@ public class DataSourceIngestMapper implements IngestMapper { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -237,13 +237,13 @@ public class DataSourceIngestMapper implements IngestMapper { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -263,13 +263,13 @@ public class DataSourceIngestMapper implements IngestMapper { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -299,10 +299,10 @@ public class DataSourceIngestMapper implements IngestMapper { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -329,13 +329,13 @@ public class DataSourceIngestMapper implements IngestMapper { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/catalog/src/main/java/org/apache/oodt/cas/catalog/repository/SerializedCatalogRepository.java ---------------------------------------------------------------------- diff --git a/catalog/src/main/java/org/apache/oodt/cas/catalog/repository/SerializedCatalogRepository.java b/catalog/src/main/java/org/apache/oodt/cas/catalog/repository/SerializedCatalogRepository.java index 7cbb8ff..65465bb 100644 --- a/catalog/src/main/java/org/apache/oodt/cas/catalog/repository/SerializedCatalogRepository.java +++ b/catalog/src/main/java/org/apache/oodt/cas/catalog/repository/SerializedCatalogRepository.java @@ -89,7 +89,7 @@ public class SerializedCatalogRepository implements CatalogRepository { }finally { try { catalogIn.close(); - }catch (Exception e) {} + }catch (Exception ignored) {} } } @@ -136,7 +136,7 @@ public class SerializedCatalogRepository implements CatalogRepository { }finally { try { catalogOut.close(); - }catch (Exception e) {} + }catch (Exception ignored) {} } } @@ -156,7 +156,7 @@ public class SerializedCatalogRepository implements CatalogRepository { }finally { try { urlsOut.close(); - }catch (Exception e) {} + }catch (Exception ignored) {} } } @@ -172,7 +172,7 @@ public class SerializedCatalogRepository implements CatalogRepository { }finally { try { urlsIn.close(); - }catch (Exception e) {} + }catch (Exception ignored) {} } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/xmlrpc/XmlRpcCommunicationChannelServer.java ---------------------------------------------------------------------- diff --git a/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/xmlrpc/XmlRpcCommunicationChannelServer.java b/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/xmlrpc/XmlRpcCommunicationChannelServer.java index 0b62850..7d5248d 100644 --- a/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/xmlrpc/XmlRpcCommunicationChannelServer.java +++ b/catalog/src/main/java/org/apache/oodt/cas/catalog/server/channel/xmlrpc/XmlRpcCommunicationChannelServer.java @@ -147,7 +147,7 @@ public class XmlRpcCommunicationChannelServer extends } finally { try { fOut.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } return true; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/catalog/src/main/java/org/apache/oodt/cas/catalog/struct/impl/index/DataSourceIndex.java ---------------------------------------------------------------------- diff --git a/catalog/src/main/java/org/apache/oodt/cas/catalog/struct/impl/index/DataSourceIndex.java b/catalog/src/main/java/org/apache/oodt/cas/catalog/struct/impl/index/DataSourceIndex.java index e9a945a..52e8e78 100644 --- a/catalog/src/main/java/org/apache/oodt/cas/catalog/struct/impl/index/DataSourceIndex.java +++ b/catalog/src/main/java/org/apache/oodt/cas/catalog/struct/impl/index/DataSourceIndex.java @@ -86,13 +86,13 @@ public class DataSourceIndex implements Index, IngestService, QueryService { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -169,13 +169,13 @@ public class DataSourceIndex implements Index, IngestService, QueryService { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -198,10 +198,10 @@ public class DataSourceIndex implements Index, IngestService, QueryService { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -236,10 +236,10 @@ public class DataSourceIndex implements Index, IngestService, QueryService { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -268,10 +268,10 @@ public class DataSourceIndex implements Index, IngestService, QueryService { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -302,10 +302,10 @@ public class DataSourceIndex implements Index, IngestService, QueryService { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -339,13 +339,13 @@ public class DataSourceIndex implements Index, IngestService, QueryService { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -386,13 +386,13 @@ public class DataSourceIndex implements Index, IngestService, QueryService { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -419,13 +419,13 @@ public class DataSourceIndex implements Index, IngestService, QueryService { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -453,13 +453,13 @@ public class DataSourceIndex implements Index, IngestService, QueryService { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/catalog/src/main/java/org/apache/oodt/cas/catalog/struct/impl/index/WorkflowManagerDataSourceIndex.java ---------------------------------------------------------------------- diff --git a/catalog/src/main/java/org/apache/oodt/cas/catalog/struct/impl/index/WorkflowManagerDataSourceIndex.java b/catalog/src/main/java/org/apache/oodt/cas/catalog/struct/impl/index/WorkflowManagerDataSourceIndex.java index aaebda5..c331c1a 100644 --- a/catalog/src/main/java/org/apache/oodt/cas/catalog/struct/impl/index/WorkflowManagerDataSourceIndex.java +++ b/catalog/src/main/java/org/apache/oodt/cas/catalog/struct/impl/index/WorkflowManagerDataSourceIndex.java @@ -98,13 +98,13 @@ public class WorkflowManagerDataSourceIndex implements Index, QueryService { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -130,13 +130,13 @@ public class WorkflowManagerDataSourceIndex implements Index, QueryService { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -169,13 +169,13 @@ public class WorkflowManagerDataSourceIndex implements Index, QueryService { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -201,13 +201,13 @@ public class WorkflowManagerDataSourceIndex implements Index, QueryService { }finally { try { conn.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { stmt.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} try { rs.close(); - }catch(Exception e) {} + }catch(Exception ignored) {} } } @@ -235,15 +235,15 @@ public class WorkflowManagerDataSourceIndex implements Index, QueryService { } finally { try { conn.close(); - } catch (Exception e) { + } catch (Exception ignored) { } try { stmt.close(); - } catch (Exception e) { + } catch (Exception ignored) { } try { rs.close(); - } catch (Exception e) { + } catch (Exception ignored) { } } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/catalog/src/main/java/org/apache/oodt/cas/catalog/system/impl/CatalogServiceLocal.java ---------------------------------------------------------------------- diff --git a/catalog/src/main/java/org/apache/oodt/cas/catalog/system/impl/CatalogServiceLocal.java b/catalog/src/main/java/org/apache/oodt/cas/catalog/system/impl/CatalogServiceLocal.java index 8cbf1f5..9346255 100644 --- a/catalog/src/main/java/org/apache/oodt/cas/catalog/system/impl/CatalogServiceLocal.java +++ b/catalog/src/main/java/org/apache/oodt/cas/catalog/system/impl/CatalogServiceLocal.java @@ -191,7 +191,7 @@ public class CatalogServiceLocal implements CatalogService { if (!this.containsCatalog(catalogId)) { try { this.replaceCatalog(new Catalog(catalogId, index, null, false, false)); - }catch (Exception e) { + }catch (Exception ignored) { } } else { @@ -203,7 +203,7 @@ public class CatalogServiceLocal implements CatalogService { if (!this.containsCatalog(catalogId)) { try { this.replaceCatalog(new Catalog(catalogId, index, dictionaries, false, false)); - }catch (Exception e) { + }catch (Exception ignored) { } } else { @@ -215,7 +215,7 @@ public class CatalogServiceLocal implements CatalogService { if (!this.containsCatalog(catalogId)) { try { this.replaceCatalog(new Catalog(catalogId, index, dictionaries, restrictQueryPermission, restrictIngestPermission)); - }catch (Exception e) { + }catch (Exception ignored) { } } else { http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/catalog/src/main/java/org/apache/oodt/cas/catalog/util/PluginClassLoader.java ---------------------------------------------------------------------- diff --git a/catalog/src/main/java/org/apache/oodt/cas/catalog/util/PluginClassLoader.java b/catalog/src/main/java/org/apache/oodt/cas/catalog/util/PluginClassLoader.java index d1c7d7d..c72f6fb 100644 --- a/catalog/src/main/java/org/apache/oodt/cas/catalog/util/PluginClassLoader.java +++ b/catalog/src/main/java/org/apache/oodt/cas/catalog/util/PluginClassLoader.java @@ -78,7 +78,7 @@ public class PluginClassLoader extends URLClassLoader { } } } - }catch (Exception e) {} + }catch (Exception ignored) {} return urls.toArray(new URL[urls.size()]); } @@ -88,7 +88,7 @@ public class PluginClassLoader extends URLClassLoader { if (clazz == null) clazz = this.findClass(name); return clazz; - }catch (Exception e) {} + }catch (Exception ignored) {} return super.loadClass(name, resolve); } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/commons/src/main/java/org/apache/oodt/commons/MultiServer.java ---------------------------------------------------------------------- diff --git a/commons/src/main/java/org/apache/oodt/commons/MultiServer.java b/commons/src/main/java/org/apache/oodt/commons/MultiServer.java index b26ed09..f320bd4 100644 --- a/commons/src/main/java/org/apache/oodt/commons/MultiServer.java +++ b/commons/src/main/java/org/apache/oodt/commons/MultiServer.java @@ -571,7 +571,7 @@ public class MultiServer { public void run() { try { context.rebind(name, servant); - } catch (NamingException ex) {} + } catch (NamingException ignored) {} } } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/commons/src/main/java/org/apache/oodt/commons/activity/SQLDatabaseRetrieval.java ---------------------------------------------------------------------- diff --git a/commons/src/main/java/org/apache/oodt/commons/activity/SQLDatabaseRetrieval.java b/commons/src/main/java/org/apache/oodt/commons/activity/SQLDatabaseRetrieval.java index 276f7d3..3d1197f 100644 --- a/commons/src/main/java/org/apache/oodt/commons/activity/SQLDatabaseRetrieval.java +++ b/commons/src/main/java/org/apache/oodt/commons/activity/SQLDatabaseRetrieval.java @@ -161,7 +161,7 @@ public class SQLDatabaseRetrieval implements Retrieval { if (stmt != null) stmt.close(); if (conn != null) conn.close(); } - catch (SQLException e) {} + catch (SQLException ignored) {} } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/commons/src/main/java/org/apache/oodt/commons/exec/EnvUtilities.java ---------------------------------------------------------------------- diff --git a/commons/src/main/java/org/apache/oodt/commons/exec/EnvUtilities.java b/commons/src/main/java/org/apache/oodt/commons/exec/EnvUtilities.java index 3e7fd2c..9e0eafd 100644 --- a/commons/src/main/java/org/apache/oodt/commons/exec/EnvUtilities.java +++ b/commons/src/main/java/org/apache/oodt/commons/exec/EnvUtilities.java @@ -105,17 +105,17 @@ public final class EnvUtilities { try { if (p.getErrorStream() != null) p.getErrorStream().close(); - } catch (Exception e) { + } catch (Exception ignored) { } try { if (p.getInputStream() != null) p.getInputStream().close(); - } catch (Exception e) { + } catch (Exception ignored) { } try { if (p.getOutputStream() != null) p.getOutputStream().close(); - } catch (Exception e) { + } catch (Exception ignored) { } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/commons/src/main/java/org/apache/oodt/commons/exec/ExecHelper.java ---------------------------------------------------------------------- diff --git a/commons/src/main/java/org/apache/oodt/commons/exec/ExecHelper.java b/commons/src/main/java/org/apache/oodt/commons/exec/ExecHelper.java index b6730a5..6429cfe 100644 --- a/commons/src/main/java/org/apache/oodt/commons/exec/ExecHelper.java +++ b/commons/src/main/java/org/apache/oodt/commons/exec/ExecHelper.java @@ -402,13 +402,13 @@ public final class ExecHelper { }finally { try { process.getErrorStream().close(); - } catch (Exception e) {} + } catch (Exception ignored) {} try { process.getInputStream().close(); - } catch (Exception e) {} + } catch (Exception ignored) {} try { process.getOutputStream().close(); - } catch (Exception e) {} + } catch (Exception ignored) {} } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/commons/src/main/java/org/apache/oodt/commons/object/jndi/ObjectNameParser.java ---------------------------------------------------------------------- diff --git a/commons/src/main/java/org/apache/oodt/commons/object/jndi/ObjectNameParser.java b/commons/src/main/java/org/apache/oodt/commons/object/jndi/ObjectNameParser.java index 3b9f06e..9673c33 100644 --- a/commons/src/main/java/org/apache/oodt/commons/object/jndi/ObjectNameParser.java +++ b/commons/src/main/java/org/apache/oodt/commons/object/jndi/ObjectNameParser.java @@ -26,7 +26,7 @@ import javax.naming.NamingException; * @author Kelly */ class ObjectNameParser implements NameParser { - private static Properties syntax = new Properties(); { + private static Properties syntax = new Properties(); static { syntax.put("jndi.syntax.direction", "flat"); syntax.put("jndi.syntax.ignorecase", "false"); } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/commons/src/test/java/org/apache/oodt/commons/activity/CompositeActivityTest.java ---------------------------------------------------------------------- diff --git a/commons/src/test/java/org/apache/oodt/commons/activity/CompositeActivityTest.java b/commons/src/test/java/org/apache/oodt/commons/activity/CompositeActivityTest.java index 7444fd6..a87c769 100755 --- a/commons/src/test/java/org/apache/oodt/commons/activity/CompositeActivityTest.java +++ b/commons/src/test/java/org/apache/oodt/commons/activity/CompositeActivityTest.java @@ -1,19 +1,19 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ package org.apache.oodt.commons.activity; @@ -40,11 +40,11 @@ public class CompositeActivityTest extends TestCase { try { new CompositeActivity(null); fail("Can contruct CompositeActivity with null collection"); - } catch (IllegalArgumentException good) {} + } catch (IllegalArgumentException ignored) {} try { new CompositeActivity(Collections.singleton("hello")); fail("Can construct CompositeActivity with non-Activity in collection"); - } catch (IllegalArgumentException good) {} + } catch (IllegalArgumentException ignored) {} CompositeActivity ca = new CompositeActivity(Collections.singleton(new TestActivity())); Incident i = new Incident(); ca.log(i); http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/commons/src/test/java/org/apache/oodt/commons/activity/DatagramLoggingActivityFactoryTest.java ---------------------------------------------------------------------- diff --git a/commons/src/test/java/org/apache/oodt/commons/activity/DatagramLoggingActivityFactoryTest.java b/commons/src/test/java/org/apache/oodt/commons/activity/DatagramLoggingActivityFactoryTest.java index e172843..3d29760 100755 --- a/commons/src/test/java/org/apache/oodt/commons/activity/DatagramLoggingActivityFactoryTest.java +++ b/commons/src/test/java/org/apache/oodt/commons/activity/DatagramLoggingActivityFactoryTest.java @@ -70,7 +70,7 @@ public class DatagramLoggingActivityFactoryTest extends TestCase { try { new DatagramLoggingActivityFactory(); fail("Can make a DatagramLoggingActivityFactory without host property set"); - } catch (IllegalStateException ex) {} + } catch (IllegalStateException ignored) {} System.setProperty("org.apache.oodt.commons.activity.DatagramLoggingActivityFactory.host", "localhost"); System.setProperty("activity.host", "non-existent-host"); http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/commons/src/test/java/org/apache/oodt/commons/activity/HistoryTest.java ---------------------------------------------------------------------- diff --git a/commons/src/test/java/org/apache/oodt/commons/activity/HistoryTest.java b/commons/src/test/java/org/apache/oodt/commons/activity/HistoryTest.java index b2bc65c..dbe8b4f 100755 --- a/commons/src/test/java/org/apache/oodt/commons/activity/HistoryTest.java +++ b/commons/src/test/java/org/apache/oodt/commons/activity/HistoryTest.java @@ -71,7 +71,7 @@ public class HistoryTest extends TestCase implements Storage { try { history.addIncident(three); fail("Able to add Incidents with non-matching activity IDs"); - } catch (IllegalArgumentException good) {} + } catch (IllegalArgumentException ignored) {} } /** http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/commons/src/test/java/org/apache/oodt/commons/io/FixedBufferOutputStreamTest.java ---------------------------------------------------------------------- diff --git a/commons/src/test/java/org/apache/oodt/commons/io/FixedBufferOutputStreamTest.java b/commons/src/test/java/org/apache/oodt/commons/io/FixedBufferOutputStreamTest.java index b08ee73..5de8ebe 100644 --- a/commons/src/test/java/org/apache/oodt/commons/io/FixedBufferOutputStreamTest.java +++ b/commons/src/test/java/org/apache/oodt/commons/io/FixedBufferOutputStreamTest.java @@ -38,32 +38,32 @@ public class FixedBufferOutputStreamTest extends TestCase { try { new FixedBufferOutputStream(-1); fail("Illegal size failed to throw exception"); - } catch (IllegalArgumentException good) {} + } catch (IllegalArgumentException ignored) {} FixedBufferOutputStream out = new FixedBufferOutputStream(100); try { out.write(null); fail("Writing a null byte array failed to throw exception"); - } catch (NullPointerException good) {} + } catch (NullPointerException ignored) {} try { out.write(null, 0, 10); fail("Writing a null byte array failed to throw exception"); - } catch (NullPointerException good) {} + } catch (NullPointerException ignored) {} try { out.write(TEST_DATA, -1, 10); fail("Writing with negative offset failed to throw exception"); - } catch (IndexOutOfBoundsException good) {} + } catch (IndexOutOfBoundsException ignored) {} try { out.write(TEST_DATA, TEST_DATA.length + 1, 10); fail("Writing with offset past end of array failed to throw exception"); - } catch (IndexOutOfBoundsException good) {} + } catch (IndexOutOfBoundsException ignored) {} try { out.write(TEST_DATA, 0, -1); fail("Writing with negative length array failed to throw exception"); - } catch (IndexOutOfBoundsException good) {} + } catch (IndexOutOfBoundsException ignored) {} try { out.write(TEST_DATA, 2, 5); fail("Writing with offset and length exceeding end of array failed to throw exception"); - } catch (IndexOutOfBoundsException good) {} + } catch (IndexOutOfBoundsException ignored) {} } /** Test a stream with space for no bytes at all. @@ -172,7 +172,7 @@ public class FixedBufferOutputStreamTest extends TestCase { try { // ...and try... out.write(1); // ...to write to it fail("Writing to a closed stream failed to throw an exception"); // Shouldn't get here - } catch (IOException good) {} // Should get here + } catch (IOException ignored) {} // Should get here } /** Some test data in an array. */ http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/commons/src/test/java/org/apache/oodt/commons/object/jndi/ObjectContextTest.java ---------------------------------------------------------------------- diff --git a/commons/src/test/java/org/apache/oodt/commons/object/jndi/ObjectContextTest.java b/commons/src/test/java/org/apache/oodt/commons/object/jndi/ObjectContextTest.java index 899c1e7..327afa7 100644 --- a/commons/src/test/java/org/apache/oodt/commons/object/jndi/ObjectContextTest.java +++ b/commons/src/test/java/org/apache/oodt/commons/object/jndi/ObjectContextTest.java @@ -87,13 +87,13 @@ public class ObjectContextTest extends TestCase { try { context.lookup("urn:a:x"); fail("Found nonexistent object"); - } catch (NamingException ex) {} + } catch (NamingException ignored) {} // Test binding names that don't match any delegate's namespace prefix. try { context.bind("urn:c:x", this); fail("Bound nonconforming name"); - } catch (NamingException ex) {} + } catch (NamingException ignored) {} // Test binding and retrieval context.bind("urn:a:x", this); // Bind something @@ -113,7 +113,7 @@ public class ObjectContextTest extends TestCase { try { context.bind("urn:a:x", ""); fail("Able to bind an already-bound name"); - } catch (NamingException ex) {} + } catch (NamingException ignored) {} // Test rebinding a bound name context.rebind("urn:a:x", context); // Bind to a different object @@ -127,7 +127,7 @@ public class ObjectContextTest extends TestCase { try { context.lookup("urn:a:x"); // Look it up fail("Found object under old name"); - } catch (NamingException ex) {} + } catch (NamingException ignored) {} assertSame(context, context.lookup("urn:a:y")); // Just the name has changed assertTrue(a1.bindings.keySet().contains("urn:a:y")); // The new name is in a1 assertTrue(!a1.bindings.keySet().contains("urn:a:x")); // But not the old @@ -178,7 +178,7 @@ public class ObjectContextTest extends TestCase { try { context.lookup("urn:a:y"); // Look it up fail("Found unbound object"); - } catch (NamingException ex) {} + } catch (NamingException ignored) {} assertTrue(a1.bindings.isEmpty()); // It's not in a1... assertTrue(a2.bindings.isEmpty()); // ...nor in a2 } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/commons/src/test/java/org/apache/oodt/commons/object/jndi/TestContextTest.java ---------------------------------------------------------------------- diff --git a/commons/src/test/java/org/apache/oodt/commons/object/jndi/TestContextTest.java b/commons/src/test/java/org/apache/oodt/commons/object/jndi/TestContextTest.java index f433a1f..523f8bc 100644 --- a/commons/src/test/java/org/apache/oodt/commons/object/jndi/TestContextTest.java +++ b/commons/src/test/java/org/apache/oodt/commons/object/jndi/TestContextTest.java @@ -50,12 +50,12 @@ public class TestContextTest extends TestCase { try { ctx.lookup("urn:x:y"); // Lookup a nonexistent binding fail("Got a binding that doesn't exist"); // Got something? Yikes. - } catch (NameNotFoundException ex) {} + } catch (NameNotFoundException ignored) {} try { ctx.bind("urn:y:z", this); // Bind an invalid prefix fail("Bound an invalid prefix"); // Worked? Dang. - } catch (InvalidNameException ex) {} + } catch (InvalidNameException ignored) {} ctx.bind("urn:x:a", this); // Bind something. assertSame(this, ctx.lookup("urn:x:a")); // Look it up @@ -63,7 +63,7 @@ public class TestContextTest extends TestCase { try { ctx.bind("urn:x:a", getClass()); // Bind it again fail("Able to re-bind"); // Worked? Crap. - } catch (NameAlreadyBoundException ex) {} + } catch (NameAlreadyBoundException ignored) {} ctx.rebind("urn:x:a", getClass()); // Rebind it again assertSame(getClass(), ctx.lookup("urn:x:a")); // Look it up http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrClient.java ---------------------------------------------------------------------- diff --git a/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrClient.java b/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrClient.java index 7b2c016..dbae244 100644 --- a/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrClient.java +++ b/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrClient.java @@ -305,7 +305,7 @@ public class SolrClient { } finally { // must release the connection even if an exception occurred method.releaseConnection(); - if (br!=null) try { br.close(); } catch (Exception e) {} + if (br!=null) try { br.close(); } catch (Exception ignored) {} } return response.toString(); http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/RemoteDataTransferer.java ---------------------------------------------------------------------- diff --git a/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/RemoteDataTransferer.java b/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/RemoteDataTransferer.java index 5f9f287..66c8172 100644 --- a/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/RemoteDataTransferer.java +++ b/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/RemoteDataTransferer.java @@ -187,7 +187,7 @@ public class RemoteDataTransferer implements DataTransfer { } finally { try { fOut.close(); - } catch (Exception e) { + } catch (Exception ignored) { } } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/S3DataTransferer.java ---------------------------------------------------------------------- diff --git a/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/S3DataTransferer.java b/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/S3DataTransferer.java index 1c813f1..e7f9385 100644 --- a/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/S3DataTransferer.java +++ b/filemgr/src/main/java/org/apache/oodt/cas/filemgr/datatransfer/S3DataTransferer.java @@ -116,8 +116,8 @@ public class S3DataTransferer implements DataTransfer { stripProtocol(ref.getDataStoreReference(), false)).getName())); IOUtils.copy(inStream, outStream); } finally { - try { inStream.close(); } catch (Exception e) {} - try { outStream.close(); } catch (Exception e) {} + try { inStream.close(); } catch (Exception ignored) {} + try { outStream.close(); } catch (Exception ignored) {} } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/filemgr/src/main/java/org/apache/oodt/cas/filemgr/ingest/RmiCache.java ---------------------------------------------------------------------- diff --git a/filemgr/src/main/java/org/apache/oodt/cas/filemgr/ingest/RmiCache.java b/filemgr/src/main/java/org/apache/oodt/cas/filemgr/ingest/RmiCache.java index df3e2a9..702b537 100644 --- a/filemgr/src/main/java/org/apache/oodt/cas/filemgr/ingest/RmiCache.java +++ b/filemgr/src/main/java/org/apache/oodt/cas/filemgr/ingest/RmiCache.java @@ -59,7 +59,7 @@ public class RmiCache implements Cache { public void clear() { try { rmiCacheServer.clear(); - } catch (RemoteException e) { + } catch (RemoteException ignored) { } } @@ -85,7 +85,7 @@ public class RmiCache implements Cache { public void setFileManager(URL fmUrl) { try { rmiCacheServer.setFileManager(fmUrl); - } catch (RemoteException e) { + } catch (RemoteException ignored) { } @@ -144,7 +144,7 @@ public class RmiCache implements Cache { try { rmiCacheServer .setUniqueElementProductTypeNames(uniqueElementProductTypeNames); - } catch (RemoteException e) { + } catch (RemoteException ignored) { } } @@ -170,7 +170,7 @@ public class RmiCache implements Cache { public void setUniqueElementName(String uniqueElementName) { try { rmiCacheServer.setUniqueElementName(uniqueElementName); - } catch (RemoteException e) { + } catch (RemoteException ignored) { } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/profile/src/main/java/org/apache/oodt/profile/Profile.java ---------------------------------------------------------------------- diff --git a/profile/src/main/java/org/apache/oodt/profile/Profile.java b/profile/src/main/java/org/apache/oodt/profile/Profile.java index 69820b5..255c649 100644 --- a/profile/src/main/java/org/apache/oodt/profile/Profile.java +++ b/profile/src/main/java/org/apache/oodt/profile/Profile.java @@ -200,7 +200,7 @@ public class Profile implements Serializable, Cloneable, Comparable<Object>, Doc Object clone = null; try { clone = super.clone(); - } catch (CloneNotSupportedException cantHappen) {} + } catch (CloneNotSupportedException ignored) {} return clone; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/profile/src/main/java/org/apache/oodt/profile/ProfileAttributes.java ---------------------------------------------------------------------- diff --git a/profile/src/main/java/org/apache/oodt/profile/ProfileAttributes.java b/profile/src/main/java/org/apache/oodt/profile/ProfileAttributes.java index 3b17624..fca45dd 100644 --- a/profile/src/main/java/org/apache/oodt/profile/ProfileAttributes.java +++ b/profile/src/main/java/org/apache/oodt/profile/ProfileAttributes.java @@ -126,7 +126,7 @@ public class ProfileAttributes implements Serializable, Cloneable, Comparable, D Object clone = null; try { clone = super.clone(); - } catch (CloneNotSupportedException cantHappen) {} + } catch (CloneNotSupportedException ignored) {} return clone; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/profile/src/main/java/org/apache/oodt/profile/ProfileElement.java ---------------------------------------------------------------------- diff --git a/profile/src/main/java/org/apache/oodt/profile/ProfileElement.java b/profile/src/main/java/org/apache/oodt/profile/ProfileElement.java index 58664dc..e1420ee 100644 --- a/profile/src/main/java/org/apache/oodt/profile/ProfileElement.java +++ b/profile/src/main/java/org/apache/oodt/profile/ProfileElement.java @@ -172,7 +172,7 @@ public abstract class ProfileElement implements Serializable, Cloneable, Compara Object obj = null; try { obj = super.clone(); - } catch (CloneNotSupportedException cantHappen) {} + } catch (CloneNotSupportedException ignored) {} return obj; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/profile/src/main/java/org/apache/oodt/profile/ResourceAttributes.java ---------------------------------------------------------------------- diff --git a/profile/src/main/java/org/apache/oodt/profile/ResourceAttributes.java b/profile/src/main/java/org/apache/oodt/profile/ResourceAttributes.java index d414ce9..c27ed77 100644 --- a/profile/src/main/java/org/apache/oodt/profile/ResourceAttributes.java +++ b/profile/src/main/java/org/apache/oodt/profile/ResourceAttributes.java @@ -194,7 +194,7 @@ public class ResourceAttributes implements Serializable, Cloneable, Comparable<O Object clone = null; try { clone = super.clone(); - } catch (CloneNotSupportedException cantHappen) {} + } catch (CloneNotSupportedException ignored) {} return clone; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/profile/src/test/java/org/apache/oodt/profile/EnumeratedProfileElementTest.java ---------------------------------------------------------------------- diff --git a/profile/src/test/java/org/apache/oodt/profile/EnumeratedProfileElementTest.java b/profile/src/test/java/org/apache/oodt/profile/EnumeratedProfileElementTest.java index c89a79d..d8defac 100644 --- a/profile/src/test/java/org/apache/oodt/profile/EnumeratedProfileElementTest.java +++ b/profile/src/test/java/org/apache/oodt/profile/EnumeratedProfileElementTest.java @@ -65,7 +65,7 @@ public class EnumeratedProfileElementTest extends ProfileElementTestCase { "test", "test", "test", "test", "test", Collections.EMPTY_LIST, /*obligation*/true, /*maxOccur*/1, "comment", Collections.singletonList(null)); fail("Null values must not be allowed as values in enumerated elements."); - } catch (IllegalArgumentException good) {} + } catch (IllegalArgumentException ignored) {} } protected void checkEnumFlag(String text) { http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/profile/src/test/java/org/apache/oodt/profile/ResourceAttributesTest.java ---------------------------------------------------------------------- diff --git a/profile/src/test/java/org/apache/oodt/profile/ResourceAttributesTest.java b/profile/src/test/java/org/apache/oodt/profile/ResourceAttributesTest.java index ac216e7..b69bd37 100644 --- a/profile/src/test/java/org/apache/oodt/profile/ResourceAttributesTest.java +++ b/profile/src/test/java/org/apache/oodt/profile/ResourceAttributesTest.java @@ -166,7 +166,7 @@ public class ResourceAttributesTest extends TestCase { t.transform(s, r); } - static ResourceAttributes TEST_RESOURCE_ATTRIBUTES; { + static ResourceAttributes TEST_RESOURCE_ATTRIBUTES; static { List contexts = Collections.singletonList("context"); List locations = Collections.singletonList("location"); TEST_RESOURCE_ATTRIBUTES = new ResourceAttributes(null, "identifier", "title", http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/protocol/api/src/main/java/org/apache/oodt/cas/protocol/cli/action/CrossProtocolTransferCliAction.java ---------------------------------------------------------------------- diff --git a/protocol/api/src/main/java/org/apache/oodt/cas/protocol/cli/action/CrossProtocolTransferCliAction.java b/protocol/api/src/main/java/org/apache/oodt/cas/protocol/cli/action/CrossProtocolTransferCliAction.java index 84feeb8..94005e7 100644 --- a/protocol/api/src/main/java/org/apache/oodt/cas/protocol/cli/action/CrossProtocolTransferCliAction.java +++ b/protocol/api/src/main/java/org/apache/oodt/cas/protocol/cli/action/CrossProtocolTransferCliAction.java @@ -107,7 +107,7 @@ public class CrossProtocolTransferCliAction extends ProtocolCliAction { } finally { try { bogusFile.delete(); - } catch (Exception e) { + } catch (Exception ignored) { } } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/protocol/api/src/main/java/org/apache/oodt/cas/protocol/verify/BasicProtocolVerifier.java ---------------------------------------------------------------------- diff --git a/protocol/api/src/main/java/org/apache/oodt/cas/protocol/verify/BasicProtocolVerifier.java b/protocol/api/src/main/java/org/apache/oodt/cas/protocol/verify/BasicProtocolVerifier.java index 93df18c..f3921c3 100644 --- a/protocol/api/src/main/java/org/apache/oodt/cas/protocol/verify/BasicProtocolVerifier.java +++ b/protocol/api/src/main/java/org/apache/oodt/cas/protocol/verify/BasicProtocolVerifier.java @@ -75,7 +75,7 @@ public class BasicProtocolVerifier implements ProtocolVerifier { + " failed compatibility test : " + e.getMessage(), e); return false; } finally { - try { protocol.close(); } catch (Exception e) {} + try { protocol.close(); } catch (Exception ignored) {} } return true; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/protocol/api/src/test/java/org/apache/oodt/cas/protocol/auth/TestBasicAuthentication.java ---------------------------------------------------------------------- diff --git a/protocol/api/src/test/java/org/apache/oodt/cas/protocol/auth/TestBasicAuthentication.java b/protocol/api/src/test/java/org/apache/oodt/cas/protocol/auth/TestBasicAuthentication.java index 149e583..ab40e7f 100644 --- a/protocol/api/src/test/java/org/apache/oodt/cas/protocol/auth/TestBasicAuthentication.java +++ b/protocol/api/src/test/java/org/apache/oodt/cas/protocol/auth/TestBasicAuthentication.java @@ -36,14 +36,14 @@ public class TestBasicAuthentication extends TestCase { try { new BasicAuthentication(null, "pass"); fail("Should have thrown IllegalArgumentException"); - }catch (IllegalArgumentException e) {} + }catch (IllegalArgumentException ignored) {} try { new BasicAuthentication("user", null); fail("Should have thrown IllegalArgumentException"); - }catch (IllegalArgumentException e) {} + }catch (IllegalArgumentException ignored) {} try { new BasicAuthentication(null, null); fail("Should have thrown IllegalArgumentException"); - }catch (IllegalArgumentException e) {} + }catch (IllegalArgumentException ignored) {} } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/protocol/http/src/test/java/org/apache/oodt/cas/protocol/http/TestHttpFile.java ---------------------------------------------------------------------- diff --git a/protocol/http/src/test/java/org/apache/oodt/cas/protocol/http/TestHttpFile.java b/protocol/http/src/test/java/org/apache/oodt/cas/protocol/http/TestHttpFile.java index c9b451a..f0ad7b4 100644 --- a/protocol/http/src/test/java/org/apache/oodt/cas/protocol/http/TestHttpFile.java +++ b/protocol/http/src/test/java/org/apache/oodt/cas/protocol/http/TestHttpFile.java @@ -44,10 +44,10 @@ public class TestHttpFile extends TestCase { try { new HttpFile(null, false, new URL("http://some-site";)); fail("Should have thrown an IllegalArgumentException"); - } catch (IllegalArgumentException e) {} + } catch (IllegalArgumentException ignored) {} try { new HttpFile("/path/to/file", false, null); fail("Should have thrown an IllegalArgumentException"); - } catch (IllegalArgumentException e) {} + } catch (IllegalArgumentException ignored) {} } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/protocol/imaps/src/main/java/org/apache/oodt/cas/protocol/imaps/ImapsProtocol.java ---------------------------------------------------------------------- diff --git a/protocol/imaps/src/main/java/org/apache/oodt/cas/protocol/imaps/ImapsProtocol.java b/protocol/imaps/src/main/java/org/apache/oodt/cas/protocol/imaps/ImapsProtocol.java index b09a4d7..e5fdf5f 100644 --- a/protocol/imaps/src/main/java/org/apache/oodt/cas/protocol/imaps/ImapsProtocol.java +++ b/protocol/imaps/src/main/java/org/apache/oodt/cas/protocol/imaps/ImapsProtocol.java @@ -180,7 +180,7 @@ public class ImapsProtocol implements Protocol { } finally { try { closeFolder(currentFolder); - } catch (Exception e) { + } catch (Exception ignored) { } } } @@ -242,7 +242,7 @@ public class ImapsProtocol implements Protocol { } finally { try { closeFolder(currentFolder); - } catch (Exception e) { + } catch (Exception ignored) { } } // } @@ -271,7 +271,7 @@ public class ImapsProtocol implements Protocol { } finally { try { closeFolder(currentFolder); - } catch (Exception e) { + } catch (Exception ignored) { } } return currentFilesForCurrentFolder; @@ -368,7 +368,7 @@ public class ImapsProtocol implements Protocol { if (openCalls <= 0) { try { folder.close(true); - } catch (Exception e) { + } catch (Exception ignored) { } } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/protocol/imaps/src/test/java/org/apache/oodt/cas/protocol/imaps/TestImapsProtocol.java ---------------------------------------------------------------------- diff --git a/protocol/imaps/src/test/java/org/apache/oodt/cas/protocol/imaps/TestImapsProtocol.java b/protocol/imaps/src/test/java/org/apache/oodt/cas/protocol/imaps/TestImapsProtocol.java index 0c7501f..f2b78b3 100644 --- a/protocol/imaps/src/test/java/org/apache/oodt/cas/protocol/imaps/TestImapsProtocol.java +++ b/protocol/imaps/src/test/java/org/apache/oodt/cas/protocol/imaps/TestImapsProtocol.java @@ -69,7 +69,7 @@ public class TestImapsProtocol extends TestCase { gMail.stop(); try { imapsProtocol.close(); - } catch (Exception e) {} + } catch (Exception ignored) {} assertEquals(0, ImapsProtocol.connectCalls); } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/protocol/sftp/src/test/java/org/apache/oodt/cas/protocol/sftp/TestJschSftpProtocol.java ---------------------------------------------------------------------- diff --git a/protocol/sftp/src/test/java/org/apache/oodt/cas/protocol/sftp/TestJschSftpProtocol.java b/protocol/sftp/src/test/java/org/apache/oodt/cas/protocol/sftp/TestJschSftpProtocol.java index f1d6d74..0dd26af 100644 --- a/protocol/sftp/src/test/java/org/apache/oodt/cas/protocol/sftp/TestJschSftpProtocol.java +++ b/protocol/sftp/src/test/java/org/apache/oodt/cas/protocol/sftp/TestJschSftpProtocol.java @@ -280,8 +280,8 @@ public class TestJschSftpProtocol extends TestCase { } return publicKeyFile; } finally { - try { ps.close(); } catch (Exception ingore) {} - try { br.close(); } catch (Exception ingore) {} + try { ps.close(); } catch (Exception ignored) {} + try { br.close(); } catch (Exception ignored) {} } } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/protocol/sftp/src/test/java/org/apache/oodt/cas/protocol/sftp/UnsupportedShellProcessProvider.java ---------------------------------------------------------------------- diff --git a/protocol/sftp/src/test/java/org/apache/oodt/cas/protocol/sftp/UnsupportedShellProcessProvider.java b/protocol/sftp/src/test/java/org/apache/oodt/cas/protocol/sftp/UnsupportedShellProcessProvider.java index 826ea46..9e784b8 100644 --- a/protocol/sftp/src/test/java/org/apache/oodt/cas/protocol/sftp/UnsupportedShellProcessProvider.java +++ b/protocol/sftp/src/test/java/org/apache/oodt/cas/protocol/sftp/UnsupportedShellProcessProvider.java @@ -55,17 +55,17 @@ public final class UnsupportedShellProcessProvider extends try { stdin.getInputStream().close(); stdin.getOutputStream().close(); - } catch (Exception ex) { + } catch (Exception ignored) { } try { stdout.getInputStream().close(); stdout.getOutputStream().close(); - } catch (Exception ex1) { + } catch (Exception ignored) { } try { stderr.getInputStream().close(); stderr.getOutputStream().close(); - } catch (Exception ex2) { + } catch (Exception ignored) { } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/pushpull/src/main/java/org/apache/oodt/cas/pushpull/daemon/Daemon.java ---------------------------------------------------------------------- diff --git a/pushpull/src/main/java/org/apache/oodt/cas/pushpull/daemon/Daemon.java b/pushpull/src/main/java/org/apache/oodt/cas/pushpull/daemon/Daemon.java index cee0373..6fd2f72 100644 --- a/pushpull/src/main/java/org/apache/oodt/cas/pushpull/daemon/Daemon.java +++ b/pushpull/src/main/java/org/apache/oodt/cas/pushpull/daemon/Daemon.java @@ -301,7 +301,7 @@ public class Daemon extends UnicastRemoteObject implements DaemonRmiInterface, synchronized (this) { try { wait(length); - } catch (InterruptedException e) { + } catch (InterruptedException ignored) { } } } @@ -319,7 +319,7 @@ public class Daemon extends UnicastRemoteObject implements DaemonRmiInterface, + " on RMI registry port " + this.rmiRegPort + " has been stopped"); this.wait(0); - } catch (Exception e) { + } catch (Exception ignored) { } LOG.log(Level.INFO, "Daemon with ID = " + this.getDaemonID() + " on RMI registry port " + this.rmiRegPort + " has resumed"); http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/pushpull/src/main/java/org/apache/oodt/cas/pushpull/daemon/DaemonLauncher.java ---------------------------------------------------------------------- diff --git a/pushpull/src/main/java/org/apache/oodt/cas/pushpull/daemon/DaemonLauncher.java b/pushpull/src/main/java/org/apache/oodt/cas/pushpull/daemon/DaemonLauncher.java index 6815ba7..da42f3d 100644 --- a/pushpull/src/main/java/org/apache/oodt/cas/pushpull/daemon/DaemonLauncher.java +++ b/pushpull/src/main/java/org/apache/oodt/cas/pushpull/daemon/DaemonLauncher.java @@ -184,7 +184,7 @@ public class DaemonLauncher implements DaemonLauncherMBean { synchronized (daemonLauncher) { try { daemonLauncher.wait(); - } catch (Exception e) { + } catch (Exception ignored) { } } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/pushpull/src/main/java/org/apache/oodt/cas/pushpull/filerestrictions/renamingconventions/RenamingConvention.java ---------------------------------------------------------------------- diff --git a/pushpull/src/main/java/org/apache/oodt/cas/pushpull/filerestrictions/renamingconventions/RenamingConvention.java b/pushpull/src/main/java/org/apache/oodt/cas/pushpull/filerestrictions/renamingconventions/RenamingConvention.java index f2e0935..6fff6d8 100644 --- a/pushpull/src/main/java/org/apache/oodt/cas/pushpull/filerestrictions/renamingconventions/RenamingConvention.java +++ b/pushpull/src/main/java/org/apache/oodt/cas/pushpull/filerestrictions/renamingconventions/RenamingConvention.java @@ -139,7 +139,7 @@ public class RenamingConvention { String parentPath = ""; try { parentPath = fileToGenNewNameFor.getProtocolFile().getParent().getPath(); - } catch (Exception e) { + } catch (Exception ignored) { } return parentPath; } @@ -148,7 +148,7 @@ public class RenamingConvention { String parentFileName = ""; try { parentFileName = fileToGenNewNameFor.getProtocolFile().getParent().getName(); - } catch (Exception e) { + } catch (Exception ignored) { } return parentFileName; } @@ -158,7 +158,7 @@ public class RenamingConvention { try { grandParentPath = fileToGenNewNameFor.getProtocolFile().getParent() .getParent().getPath(); - } catch (Exception e) { + } catch (Exception ignored) { } return grandParentPath; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/ProtocolHandler.java ---------------------------------------------------------------------- diff --git a/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/ProtocolHandler.java b/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/ProtocolHandler.java index de28eb6..abecbd9 100644 --- a/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/ProtocolHandler.java +++ b/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/ProtocolHandler.java @@ -307,7 +307,7 @@ public class ProtocolHandler { wait(1000); } System.out.println(); - } catch (Exception e) { + } catch (Exception ignored) { } } } @@ -316,7 +316,7 @@ public class ProtocolHandler { // make sure protocol is disconnected try { protocol.close(); - } catch (Exception e) { + } catch (Exception ignored) { } // try connecting Protocol http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java ---------------------------------------------------------------------- diff --git a/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java b/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java index 49fec6b..d9ab5c5 100644 --- a/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java +++ b/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java @@ -382,7 +382,7 @@ public class FileRetrievalSystem { return; else this.wait(5000); - } catch (Exception e) { + } catch (Exception ignored) { } } throw new ProtocolException( @@ -483,7 +483,7 @@ public class FileRetrievalSystem { synchronized (this) { try { wait(5000); - } catch (Exception e1) { + } catch (Exception ignored) { } } } else { @@ -572,7 +572,7 @@ public class FileRetrievalSystem { while ((session = getSession(file)) == null) { try { waitMainThread(); - } catch (InterruptedException e1) { + } catch (InterruptedException ignored) { } } return session; @@ -659,7 +659,7 @@ public class FileRetrievalSystem { e.printStackTrace(); try { protocolHandler.disconnect(session); - } catch (Exception exc) { + } catch (Exception ignored) { } session = protocolHandler.getAppropriateProtocol(file, /* reuse */ false, /* navigate */true); @@ -801,7 +801,7 @@ public class FileRetrievalSystem { + e.getMessage(), e); try { protocolHandler.disconnect(curSession); - } catch (Exception exc) { + } catch (Exception ignored) { } try { curSession = protocolHandler @@ -902,7 +902,7 @@ public class FileRetrievalSystem { try { this.resetVariables(); - } catch (Exception e) { + } catch (Exception ignored) { } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/RetrievalSetup.java ---------------------------------------------------------------------- diff --git a/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/RetrievalSetup.java b/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/RetrievalSetup.java index e211aa5..3908f29 100644 --- a/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/RetrievalSetup.java +++ b/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/RetrievalSetup.java @@ -200,7 +200,7 @@ public class RetrievalSetup { synchronized (this) { try { this.wait(5000); - } catch (Exception e) { + } catch (Exception ignored) { } } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/XmlRpcBatchMgr.java ---------------------------------------------------------------------- diff --git a/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/XmlRpcBatchMgr.java b/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/XmlRpcBatchMgr.java index 3c7c28b..7b34708 100644 --- a/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/XmlRpcBatchMgr.java +++ b/resource/src/main/java/org/apache/oodt/cas/resource/batchmgr/XmlRpcBatchMgr.java @@ -165,7 +165,7 @@ public class XmlRpcBatchMgr implements Batchmgr { int reducedLoad = job.getLoadValue(); try { mon.reduceLoad(node, reducedLoad); - } catch (MonitorException e) { + } catch (MonitorException ignored) { } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/resource/src/main/java/org/apache/oodt/cas/resource/jobrepo/XStreamJobRepository.java ---------------------------------------------------------------------- diff --git a/resource/src/main/java/org/apache/oodt/cas/resource/jobrepo/XStreamJobRepository.java b/resource/src/main/java/org/apache/oodt/cas/resource/jobrepo/XStreamJobRepository.java index a931bcb..93ba9cc 100644 --- a/resource/src/main/java/org/apache/oodt/cas/resource/jobrepo/XStreamJobRepository.java +++ b/resource/src/main/java/org/apache/oodt/cas/resource/jobrepo/XStreamJobRepository.java @@ -82,7 +82,7 @@ public class XStreamJobRepository implements JobRepository { }finally { try { os.close(); - }catch (Exception e) {} + }catch (Exception ignored) {} } } @@ -97,7 +97,7 @@ public class XStreamJobRepository implements JobRepository { }finally { try { is.close(); - }catch (Exception e) {} + }catch (Exception ignored) {} } } @@ -132,7 +132,7 @@ public class XStreamJobRepository implements JobRepository { }finally { try { os.close(); - }catch (Exception e) {} + }catch (Exception ignored) {} } } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/resource/src/test/java/org/apache/oodt/cas/resource/mux/TestQueueMuxBatchmgr.java ---------------------------------------------------------------------- diff --git a/resource/src/test/java/org/apache/oodt/cas/resource/mux/TestQueueMuxBatchmgr.java b/resource/src/test/java/org/apache/oodt/cas/resource/mux/TestQueueMuxBatchmgr.java index 0541c81..fb7b2e8 100644 --- a/resource/src/test/java/org/apache/oodt/cas/resource/mux/TestQueueMuxBatchmgr.java +++ b/resource/src/test/java/org/apache/oodt/cas/resource/mux/TestQueueMuxBatchmgr.java @@ -70,7 +70,7 @@ public class TestQueueMuxBatchmgr extends TestCase { try { queue.executeRemotely(this.getSpecFromQueue("queue-3"),node1); TestCase.fail("Failed to throw JobExecutionException on unknown queue."); - } catch(JobExecutionException e) {} + } catch(JobExecutionException ignored) {} } catch (JobExecutionException e) { TestCase.fail("Unexpected Exception: "+e.getMessage()); } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/resource/src/test/java/org/apache/oodt/cas/resource/mux/TestQueueMuxMonitor.java ---------------------------------------------------------------------- diff --git a/resource/src/test/java/org/apache/oodt/cas/resource/mux/TestQueueMuxMonitor.java b/resource/src/test/java/org/apache/oodt/cas/resource/mux/TestQueueMuxMonitor.java index 8b91d5a..b2d0724 100644 --- a/resource/src/test/java/org/apache/oodt/cas/resource/mux/TestQueueMuxMonitor.java +++ b/resource/src/test/java/org/apache/oodt/cas/resource/mux/TestQueueMuxMonitor.java @@ -136,7 +136,7 @@ public class TestQueueMuxMonitor extends TestCase { try { monitor.reduceLoad(superfluous, 2); TestCase.fail("Exception not thrown for unknown queue."); - } catch (MonitorException e) {} + } catch (MonitorException ignored) {} } catch(MonitorException e) { TestCase.fail("Unanticipated monitor exception caught: "+e.getMessage()); } @@ -151,7 +151,7 @@ public class TestQueueMuxMonitor extends TestCase { try { monitor.assignLoad(superfluous, 2); TestCase.fail("Exception not thrown for unknown queue."); - } catch (MonitorException e) {} + } catch (MonitorException ignored) {} } catch(MonitorException e) { TestCase.fail("Unanticipated monitor exception caught: "+e.getMessage()); } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/TaskProcessor.java ---------------------------------------------------------------------- diff --git a/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/TaskProcessor.java b/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/TaskProcessor.java index d139e8f..613eb55 100755 --- a/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/TaskProcessor.java +++ b/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/TaskProcessor.java @@ -82,7 +82,7 @@ public class TaskProcessor extends WorkflowProcessor { try { requiredBlockTimeElapse = Integer .parseInt(requiredBlockTimeElapseString); - } catch (Exception e) { + } catch (Exception ignored) { } } Calendar calendar = Calendar.getInstance(); http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/WorkflowProcessorHelper.java ---------------------------------------------------------------------- diff --git a/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/WorkflowProcessorHelper.java b/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/WorkflowProcessorHelper.java index faa2e71..2955d27 100755 --- a/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/WorkflowProcessorHelper.java +++ b/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/WorkflowProcessorHelper.java @@ -339,7 +339,7 @@ public class WorkflowProcessorHelper { } catch (Exception e) { try { host = ExecHelper.exec(new String[] { "hostname" }).getOutput().trim(); - } catch (Exception e1) { + } catch (Exception ignored) { } } if (host == null) http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/TaskJob.java ---------------------------------------------------------------------- diff --git a/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/TaskJob.java b/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/TaskJob.java index 16ca5c7..f6975df 100644 --- a/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/TaskJob.java +++ b/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/TaskJob.java @@ -193,7 +193,7 @@ public class TaskJob implements JobInstance, WorkflowStatus, CoreMetKeys{ InetAddress addr = InetAddress.getLocalHost(); // Get the host name return addr.getHostName(); - } catch (UnknownHostException e) { + } catch (UnknownHostException ignored) { } return null; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java ---------------------------------------------------------------------- diff --git a/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java b/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java index 55e11d3..4e191a5 100644 --- a/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java +++ b/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java @@ -649,7 +649,7 @@ public class XmlRpcWorkflowManager { InetAddress addr = InetAddress.getLocalHost(); // Get the host name return addr.getHostName(); - } catch (UnknownHostException e) { + } catch (UnknownHostException ignored) { } return null; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResultInputStream.java ---------------------------------------------------------------------- diff --git a/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResultInputStream.java b/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResultInputStream.java index 3547d40..2198afe 100644 --- a/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResultInputStream.java +++ b/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResultInputStream.java @@ -34,7 +34,7 @@ class CDEResultInputStream extends InputStream { String s = null; try { s = res.getNextRowAsString(); - } catch (SQLException e) { + } catch (SQLException ignored) { } if (rowStream != null) rowStream.close(); http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/xmlquery/src/main/java/org/apache/oodt/xmlquery/CompressedObjectCodec.java ---------------------------------------------------------------------- diff --git a/xmlquery/src/main/java/org/apache/oodt/xmlquery/CompressedObjectCodec.java b/xmlquery/src/main/java/org/apache/oodt/xmlquery/CompressedObjectCodec.java index c2fb54d..c314915 100755 --- a/xmlquery/src/main/java/org/apache/oodt/xmlquery/CompressedObjectCodec.java +++ b/xmlquery/src/main/java/org/apache/oodt/xmlquery/CompressedObjectCodec.java @@ -54,7 +54,7 @@ class CompressedObjectCodec implements Codec { ObjectOutputStream objStream = new ObjectOutputStream(gzip); objStream.writeObject(object); objStream.close(); - } catch (IOException cantHappen) {} + } catch (IOException ignored) {} Element value = doc.createElement("resultValue"); value.appendChild(doc.createCDATASection(byteArray.toString())); return value; @@ -81,7 +81,7 @@ class CompressedObjectCodec implements Codec { throw ex; } catch (OptionalDataException ex) { throw ex; - } catch (IOException cantHappen) {} + } catch (IOException ignored) {} return rc; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/xmlquery/src/main/java/org/apache/oodt/xmlquery/CompressedStringCodec.java ---------------------------------------------------------------------- diff --git a/xmlquery/src/main/java/org/apache/oodt/xmlquery/CompressedStringCodec.java b/xmlquery/src/main/java/org/apache/oodt/xmlquery/CompressedStringCodec.java index d945f2d..f77be48 100755 --- a/xmlquery/src/main/java/org/apache/oodt/xmlquery/CompressedStringCodec.java +++ b/xmlquery/src/main/java/org/apache/oodt/xmlquery/CompressedStringCodec.java @@ -46,7 +46,7 @@ class CompressedStringCodec implements Codec { GZIPOutputStream gzip = new GZIPOutputStream(base64); gzip.write(object.toString().getBytes()); gzip.close(); - } catch (IOException cantHappen) {} + } catch (IOException ignored) {} Element value = doc.createElement("resultValue"); value.appendChild(doc.createCDATASection(byteArray.toString())); return value; @@ -70,7 +70,7 @@ class CompressedStringCodec implements Codec { b.append(new String(buf, 0, numRead)); gzip.close(); rc = b.toString(); - } catch (IOException cantHappen) {} + } catch (IOException ignored) {} return rc; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/xmlquery/src/main/java/org/apache/oodt/xmlquery/ObjectCodec.java ---------------------------------------------------------------------- diff --git a/xmlquery/src/main/java/org/apache/oodt/xmlquery/ObjectCodec.java b/xmlquery/src/main/java/org/apache/oodt/xmlquery/ObjectCodec.java index 1065794..0024b63 100755 --- a/xmlquery/src/main/java/org/apache/oodt/xmlquery/ObjectCodec.java +++ b/xmlquery/src/main/java/org/apache/oodt/xmlquery/ObjectCodec.java @@ -51,7 +51,7 @@ class ObjectCodec implements Codec { ObjectOutputStream objStream = new ObjectOutputStream(base64); objStream.writeObject(object); objStream.close(); - } catch (IOException cantHappen) {} + } catch (IOException ignored) {} Element value = doc.createElement("resultValue"); value.appendChild(doc.createCDATASection(byteArray.toString())); return value; @@ -77,7 +77,7 @@ class ObjectCodec implements Codec { throw ex; } catch (OptionalDataException ex) { throw ex; - } catch (IOException cantHappen) {} + } catch (IOException ignored) {} return rc; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/xmlquery/src/main/java/org/apache/oodt/xmlquery/QueryElement.java ---------------------------------------------------------------------- diff --git a/xmlquery/src/main/java/org/apache/oodt/xmlquery/QueryElement.java b/xmlquery/src/main/java/org/apache/oodt/xmlquery/QueryElement.java index 02e1a5c..2e583f1 100755 --- a/xmlquery/src/main/java/org/apache/oodt/xmlquery/QueryElement.java +++ b/xmlquery/src/main/java/org/apache/oodt/xmlquery/QueryElement.java @@ -119,7 +119,7 @@ public class QueryElement implements Serializable, Cloneable, Documentable { Object rc = null; try { rc = super.clone(); - } catch (CloneNotSupportedException cantHappen) {} + } catch (CloneNotSupportedException ignored) {} return rc; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/xmlquery/src/main/java/org/apache/oodt/xmlquery/QueryHeader.java ---------------------------------------------------------------------- diff --git a/xmlquery/src/main/java/org/apache/oodt/xmlquery/QueryHeader.java b/xmlquery/src/main/java/org/apache/oodt/xmlquery/QueryHeader.java index a03ac3f..ce26d70 100755 --- a/xmlquery/src/main/java/org/apache/oodt/xmlquery/QueryHeader.java +++ b/xmlquery/src/main/java/org/apache/oodt/xmlquery/QueryHeader.java @@ -263,7 +263,7 @@ public class QueryHeader implements Serializable, Cloneable, Documentable { Object rc = null; try { rc = super.clone(); - } catch (CloneNotSupportedException cantHappen) {} + } catch (CloneNotSupportedException ignored) {} return rc; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/xmlquery/src/main/java/org/apache/oodt/xmlquery/XMLQuery.java ---------------------------------------------------------------------- diff --git a/xmlquery/src/main/java/org/apache/oodt/xmlquery/XMLQuery.java b/xmlquery/src/main/java/org/apache/oodt/xmlquery/XMLQuery.java index 608d947..3694b74 100755 --- a/xmlquery/src/main/java/org/apache/oodt/xmlquery/XMLQuery.java +++ b/xmlquery/src/main/java/org/apache/oodt/xmlquery/XMLQuery.java @@ -869,7 +869,7 @@ public class XMLQuery implements java.io.Serializable, Cloneable { Object rc = null; try { rc = super.clone(); - } catch (CloneNotSupportedException cantHappen) {} + } catch (CloneNotSupportedException ignored) {} return rc; } http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/xmlquery/src/test/java/org/apache/oodt/xmlquery/CodecFactoryTest.java ---------------------------------------------------------------------- diff --git a/xmlquery/src/test/java/org/apache/oodt/xmlquery/CodecFactoryTest.java b/xmlquery/src/test/java/org/apache/oodt/xmlquery/CodecFactoryTest.java index 0ff095f..756ee6f 100755 --- a/xmlquery/src/test/java/org/apache/oodt/xmlquery/CodecFactoryTest.java +++ b/xmlquery/src/test/java/org/apache/oodt/xmlquery/CodecFactoryTest.java @@ -39,7 +39,7 @@ public class CodecFactoryTest extends TestCase { try { Codec codec = CodecFactory.createCodec("unknown.class.name"); fail("CodecFactory somehow created an object of an unknown class"); - } catch (RuntimeException good) {} + } catch (RuntimeException ignored) {} } public void testValidCodec() { http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/xmlquery/src/test/java/org/apache/oodt/xmlquery/HeaderTest.java ---------------------------------------------------------------------- diff --git a/xmlquery/src/test/java/org/apache/oodt/xmlquery/HeaderTest.java b/xmlquery/src/test/java/org/apache/oodt/xmlquery/HeaderTest.java index 5340546..94cd9d0 100755 --- a/xmlquery/src/test/java/org/apache/oodt/xmlquery/HeaderTest.java +++ b/xmlquery/src/test/java/org/apache/oodt/xmlquery/HeaderTest.java @@ -88,7 +88,7 @@ public class HeaderTest extends TestCase { try { Header h0 = new Header(bogus); fail("Header constructor failed to throw exception when given invalid XML node"); - } catch (IllegalArgumentException good) {} + } catch (IllegalArgumentException ignored) {} Header h1 = new Header("name1", "type1", "unit1"); Node root = h1.toXML(doc); http://git-wip-us.apache.org/repos/asf/oodt/blob/fae02f97/xmlquery/src/test/java/org/apache/oodt/xmlquery/ResultTest.java ---------------------------------------------------------------------- diff --git a/xmlquery/src/test/java/org/apache/oodt/xmlquery/ResultTest.java b/xmlquery/src/test/java/org/apache/oodt/xmlquery/ResultTest.java index 350fb38..fd3e8ed 100755 --- a/xmlquery/src/test/java/org/apache/oodt/xmlquery/ResultTest.java +++ b/xmlquery/src/test/java/org/apache/oodt/xmlquery/ResultTest.java @@ -122,7 +122,7 @@ public class ResultTest extends TestCase { try { Result r0 = new Result(bogus); fail("Result constructor failed to throw exception when given invalid XML node"); - } catch (IllegalArgumentException good) {} + } catch (IllegalArgumentException ignored) {} Result r1 = new Result("1", "text/xml", "edaDataSetInv1", "geeba1", new ArrayList(), TEST_VALUE, /*classified*/true, /*validity*/3456789);
