[
https://issues.apache.org/jira/browse/OODT-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320551#comment-16320551
]
ASF GitHub Bot commented on OODT-970:
-------------------------------------
Github user IMS94 commented on a diff in the pull request:
https://github.com/apache/oodt/pull/55#discussion_r160729693
--- Diff:
filemgr/src/test/java/org/apache/oodt/cas/filemgr/system/AbstractFileManagerServerTest.java
---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.oodt.cas.filemgr.system;
+
+import junit.framework.TestCase;
+import org.apache.oodt.cas.filemgr.ingest.StdIngester;
+import org.apache.oodt.cas.filemgr.metadata.CoreMetKeys;
+import org.apache.oodt.cas.metadata.Metadata;
+import org.apache.oodt.cas.metadata.SerializableMetadata;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.net.URL;
+import java.util.Properties;
+import java.util.logging.Logger;
+
+public abstract class AbstractFileManagerServerTest extends TestCase {
+
+ private static final Logger LOG =
Logger.getLogger(AbstractFileManagerServerTest.class.getName());
--- End diff --
Thanks for the comments @lewismc! Well, the usage of logging is confusing
since at some places it has used `java.util.Logging` and in some places it has
used `slf4j API` with `log4j-slf4j implementation`. I personally prefer
`slf4j`. But in these classes I kept what was being used.
> Netty Transceiver throws an NPE
> -------------------------------
>
> Key: OODT-970
> URL: https://issues.apache.org/jira/browse/OODT-970
> Project: OODT
> Issue Type: Test
> Components: file manager
> Reporter: Imesha Sudasingha
> Assignee: Imesha Sudasingha
> Fix For: 1.9
>
>
> Netty transceiver throws an NPE whenever the Avro File Manager client is
> called after the first time.
> {code:java}
> java.lang.NullPointerException: null
> ! at
> org.apache.avro.ipc.NettyTransceiver.getRemoteName(NettyTransceiver.java:431)
> ! at org.apache.avro.ipc.Requestor.writeHandshake(Requestor.java:202)
> ! at org.apache.avro.ipc.Requestor.access$300(Requestor.java:52)
> ! at org.apache.avro.ipc.Requestor$Request.getBytes(Requestor.java:478)
> ! at org.apache.avro.ipc.Requestor.request(Requestor.java:181)
> ! at org.apache.avro.ipc.Requestor.request(Requestor.java:129)
> ! at
> org.apache.avro.ipc.specific.SpecificRequestor.invoke(SpecificRequestor.java:84)
> {code}
> Cause is: transceiver being closed after every use inside finally{} block.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
