[
https://issues.apache.org/jira/browse/OODT-951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris A. Mattmann resolved OODT-951.
------------------------------------
Resolution: Fixed
Thanks [~lifove] appreciate it, that was indeed a bug!
{noformat}
nonas:oodt mattmann$ git commit -m "Fix for OODT-951: Wrong null checker
contributed by JC."
[master 3af750a5c] Fix for OODT-951: Wrong null checker contributed by JC.
2 files changed, 3 insertions(+), 1 deletion(-)
nonas:oodt mattmann$ git push -u origin master
Counting objects: 14, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (9/9), done.
Writing objects: 100% (14/14), 1000 bytes | 500.00 KiB/s, done.
Total 14 (delta 6), reused 0 (delta 0)
remote: oodt git commit: Fix for OODT-951: Wrong null checker contributed by JC.
To https://git-wip-us.apache.org/repos/asf/oodt.git
9e5d75d5e..3af750a5c master -> master
Branch master set up to track remote branch master from origin.
nonas:oodt mattmann${noformat}
> Wrong null checker
> ------------------
>
> Key: OODT-951
> URL: https://issues.apache.org/jira/browse/OODT-951
> Project: OODT
> Issue Type: Bug
> Components: workflow manager
> Reporter: JC
> Assignee: Chris A. Mattmann
> Priority: Minor
> Fix For: 1.9
>
>
> Hi
> In a recent Github snapshot, I've found a following code smell.
> Path:
> workflow/src/main/java/org/apache/oodt/cas/workflow/engine/PrioritizedQueueBasedWorkflowEngine.java
> {code}
> 69 public PrioritizedQueueBasedWorkflowEngine(WorkflowInstanceRepository
> repo ,
> 70 PrioritySorter prioritizer, WorkflowLifecycleManager lifecycle,
> 71 EngineRunner runner, WorkflowRepository modelRepo, long
> querierWaitSec onds) {
> 72 this.repo = repo;
> 73 this.prioritizer = prioritizer != null ? new
> HighestFIFOPrioritySorter(1 ,
> 74 50, 1) : prioritizer;
> 75 this.lifecycle = lifecycle;
> 76 this.modelRepo = modelRepo;
> {code}
> In Line 73, prioritizer != null should be prioritizer == null? This might be
> a trivial issue but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
