http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java b/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java index ca8175e..40a3c5c 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java +++ b/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java @@ -67,7 +67,7 @@ public class CoordCommandUtils { /** * parse a function like coord:latest(n)/future() and return the 'n'. - * <p/> + * <p> * * @param function * @param restArg @@ -138,7 +138,7 @@ public class CoordCommandUtils { } /** - * @param EL function name + * @param function EL function name * @return type of EL function */ public static int getFuncType(String function) { @@ -185,7 +185,7 @@ public class CoordCommandUtils { /** - * Resolve list of <instance> </instance> tags. + * Resolve list of <instance> </instance> tags. * * @param event * @param instances @@ -207,7 +207,7 @@ public class CoordCommandUtils { } /** - * Resolve <start-instance> <end-insatnce> tag. Don't resolve any + * Resolve <start-instance> <end-insatnce> tag. Don't resolve any * latest()/future() * * @param event @@ -314,7 +314,7 @@ public class CoordCommandUtils { /** * Materialize one instance like current(-2) * - * @param event : <data-in> + * @param event : <data-in> * @param expr : instance like current(-1) * @param appInst : application specific info * @param conf @@ -333,7 +333,7 @@ public class CoordCommandUtils { } /** - * Create two new tags with <uris> and <unresolved-instances>. + * Create two new tags with <uris> and <unresolved-instances>. * * @param event * @param instances @@ -366,7 +366,7 @@ public class CoordCommandUtils { * The function create a list of URIs separated by "," using the instances * time stamp and URI-template * - * @param event : <data-in> event + * @param event : <data-in> event * @param instances : List of time stamp separated by "," * @param unresolvedInstances : list of instance with latest function * @param urisWithDoneFlag : list of URIs with the done flag appended @@ -450,8 +450,8 @@ public class CoordCommandUtils { /** * Materialize one instance for specific nominal time. It includes: 1. - * Materialize data events (i.e. <data-in> and <data-out>) 2. Materialize - * data properties (i.e dataIn(<DS>) and dataOut(<DS>) 3. remove 'start' and + * Materialize data events (i.e. <data-in> and <data-out>) 2. Materialize + * data properties (i.e dataIn(<DS>) and dataOut(<DS>) 3. remove 'start' and * 'end' tag 4. Add 'instance_number' and 'nominal-time' tag * * @param jobId coordinator job id @@ -587,7 +587,7 @@ public class CoordCommandUtils { } /** - * Materialize all <input-events>/<data-in> or <output-events>/<data-out> + * Materialize all <input-events>/<data-in> or <output-events>/<data-out> * tags Create uris for resolved instances. Create unresolved instance for * latest()/future(). *
http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java b/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java index 3535e00..19b9219 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java @@ -73,12 +73,11 @@ import org.jdom.JDOMException; /** * Rerun coordinator actions by a list of dates or ids. User can specify if refresh or noCleanup. - * <p/> - * The "rerunType" can be set as {@link RestConstants.JOB_COORD_RERUN_DATE} or - * {@link RestConstants.JOB_COORD_RERUN_ACTION}. - * <p/> + * <p> + * The "rerunType" can be set as {@link RestConstants#JOB_COORD_SCOPE_DATE} or {@link RestConstants#JOB_COORD_SCOPE_ACTION}. + * <p> * The "refresh" is used to indicate if user wants to refresh an action's input and output events. - * <p/> + * <p> * The "noCleanup" is used to indicate if user wants to cleanup output events for given rerun actions */ @SuppressWarnings("deprecation") @@ -98,7 +97,7 @@ public class CoordRerunXCommand extends RerunTransitionXCommand<CoordinatorActio * The constructor for class {@link CoordRerunXCommand} * * @param jobId the job id - * @param rerunType rerun type {@link RestConstants.JOB_COORD_RERUN_DATE} or {@link RestConstants.JOB_COORD_RERUN_ACTION} + * @param rerunType rerun type {@link RestConstants#JOB_COORD_SCOPE_DATE} or {@link RestConstants#JOB_COORD_SCOPE_ACTION} * @param scope the rerun scope for given rerunType separated by "," * @param refresh true if user wants to refresh input/output dataset urls * @param noCleanup false if user wants to cleanup output events for given rerun actions http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java b/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java index ffb65d7..587b983 100644 --- a/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java @@ -90,9 +90,9 @@ import org.xml.sax.SAXException; /** * This class provides the functionalities to resolve a coordinator job XML and write the job information into a DB * table. - * <p/> + * <p> * Specifically it performs the following functions: 1. Resolve all the variables or properties using job - * configurations. 2. Insert all datasets definition as part of the <data-in> and <data-out> tags. 3. Validate the XML + * configurations. 2. Insert all datasets definition as part of the <data-in> and <data-out> tags. 3. Validate the XML * at runtime. */ public class CoordSubmitXCommand extends SubmitTransitionXCommand { http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java b/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java index cb944eb..5827387 100644 --- a/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java @@ -49,7 +49,7 @@ import org.apache.oozie.util.LogUtils; import org.apache.oozie.util.XLog; /** - * Executes the check command for ActionHandlers. </p> Ensures the action is in + * Executes the check command for ActionHandlers. <p> Ensures the action is in * RUNNING state before executing * {@link ActionExecutor#check(org.apache.oozie.action.ActionExecutor.Context, org.apache.oozie.client.WorkflowAction)} */ http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java b/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java index 69a363b..2616d32 100644 --- a/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java @@ -132,9 +132,9 @@ public abstract class ActionXCommand<T> extends WorkflowXCommand<Void> { } /** - * Takes care of errors. </p> For errors while attempting to start the action, the job state is updated and an - * {@link ActionEndCommand} is queued. </p> For errors while attempting to end the action, the job state is updated. - * </p> + * Takes care of errors. <p> For errors while attempting to start the action, the job state is updated and an + * {@link ActionEndXCommand} is queued. <p> For errors while attempting to end the action, the job state is updated. + * <p> * * @param context the execution context. * @param executor the executor instance being used. @@ -207,7 +207,7 @@ public abstract class ActionXCommand<T> extends WorkflowXCommand<Void> { /** * Execute retry for action if this action is eligible for user-retry * - * @param context the execution context. + * @param action the Workflow action bean * @return true if user-retry has to be handled for this action * @throws CommandException thrown if unable to fail job */ http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java b/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java index d39b93d..40b93d3 100644 --- a/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java @@ -54,7 +54,7 @@ import java.util.Date; import java.util.List; /** - * Kill workflow job and its workflow instance and queue a {@link WorkflowActionKillXCommand} to kill the workflow + * Kill workflow job and its workflow instance and queue a {@link ActionKillXCommand} to kill the workflow * actions. */ @SuppressWarnings("deprecation") http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java b/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java index 31996d1..178eaf4 100644 --- a/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java @@ -329,7 +329,8 @@ public class ReRunXCommand extends WorkflowXCommand<Void> { * Checks the pre-conditions that are required for workflow to recover - Last run of Workflow should be completed - * The nodes that are to be skipped are to be completed successfully in the base run. * - * @throws org.apache.oozie.command.CommandException,PreconditionException On failure of pre-conditions + * @throws CommandException + * @throws PreconditionException On failure of pre-conditions */ @Override protected void eagerVerifyPrecondition() throws CommandException, PreconditionException { http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java b/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java index 9aec702..27274b9 100644 --- a/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java +++ b/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java @@ -107,7 +107,6 @@ public class SubmitXCommand extends WorkflowXCommand<String> { * * @param dryrun : if dryrun * @param conf : Configuration for workflow job - * @param authToken : To be used for authentication */ public SubmitXCommand(boolean dryrun, Configuration conf) { this(conf); http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java b/core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java index 8a279c0..8b2f456 100644 --- a/core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java +++ b/core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java @@ -58,7 +58,7 @@ public class CoordELEvaluator { /** * Create a new Evaluator to resolve the EL functions and variables using action creation time (Phase 2) * - * @param event : Xml element for data-in element usually enclosed by <data-in(out)> tag + * @param event : Xml element for data-in element usually enclosed by <data-in(out)> tag * @param appInst : Application Instance related information such as Action creation Time * @param conf :Configuration to substitute any variables * @return configured ELEvaluator @@ -95,7 +95,7 @@ public class CoordELEvaluator { * * @param actualTime : Action start time * @param nominalTime : Action creation time - * @param dEvent :XML element for data-in element usually enclosed by <data-in(out)> tag + * @param dEvent :XML element for data-in element usually enclosed by <data-in(out)> tag * @param conf :Configuration to substitute any variables * @return configured ELEvaluator * @throws Exception : If there is any date-time string in wrong format, the exception is thrown http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java b/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java index 0cf2c44..4828a23 100644 --- a/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java +++ b/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java @@ -63,7 +63,7 @@ public class CoordELFunctions { public static final long YEAR_MSEC = 365 * DAY_MSEC; /** - * Used in defining the frequency in 'day' unit. <p/> domain: <code> val > 0</code> and should be integer. + * Used in defining the frequency in 'day' unit. <p> domain: <code> val > 0</code> and should be integer. * * @param val frequency in number of days. * @return number of days and also set the frequency timeunit to "day" @@ -77,7 +77,7 @@ public class CoordELFunctions { } /** - * Used in defining the frequency in 'month' unit. <p/> domain: <code> val > 0</code> and should be integer. + * Used in defining the frequency in 'month' unit. <p> domain: <code> val > 0</code> and should be integer. * * @param val frequency in number of months. * @return number of months and also set the frequency timeunit to "month" @@ -91,7 +91,7 @@ public class CoordELFunctions { } /** - * Used in defining the frequency in 'hour' unit. <p/> parameter value domain: <code> val > 0</code> and should + * Used in defining the frequency in 'hour' unit. <p> parameter value domain: <code> val > 0</code> and should * be integer. * * @param val frequency in number of hours. @@ -106,7 +106,7 @@ public class CoordELFunctions { } /** - * Used in defining the frequency in 'minute' unit. <p/> domain: <code> val > 0</code> and should be integer. + * Used in defining the frequency in 'minute' unit. <p> domain: <code> val > 0</code> and should be integer. * * @param val frequency in number of minutes. * @return number of minutes and also set the frequency timeunit to "minute" @@ -120,8 +120,8 @@ public class CoordELFunctions { } /** - * Used in defining the frequency in 'day' unit and specify the "end of day" property. <p/> Every instance will - * start at 00:00 hour of each day. <p/> domain: <code> val > 0</code> and should be integer. + * Used in defining the frequency in 'day' unit and specify the "end of day" property. <p> Every instance will + * start at 00:00 hour of each day. <p> domain: <code> val > 0</code> and should be integer. * * @param val frequency in number of days. * @return number of days and also set the frequency timeunit to "day" and end_of_duration flag to "day" @@ -135,8 +135,8 @@ public class CoordELFunctions { } /** - * Used in defining the frequency in 'month' unit and specify the "end of month" property. <p/> Every instance will - * start at first day of each month at 00:00 hour. <p/> domain: <code> val > 0</code> and should be integer. + * Used in defining the frequency in 'month' unit and specify the "end of month" property. <p> Every instance will + * start at first day of each month at 00:00 hour. <p> domain: <code> val > 0</code> and should be integer. * * @param val: frequency in number of months. * @return number of months and also set the frequency timeunit to "month" and end_of_duration flag to "month" @@ -150,8 +150,8 @@ public class CoordELFunctions { } /** - * Calculate the difference of timezone offset in minutes between dataset and coordinator job. <p/> Depends on: <p/> - * 1. Timezone of both dataset and job <p/> 2. Action creation Time + * Calculate the difference of timezone offset in minutes between dataset and coordinator job. <p> Depends on: <p> + * 1. Timezone of both dataset and job <p> 2. Action creation Time * * @return difference in minutes (DataSet TZ Offset - Application TZ offset) */ @@ -212,30 +212,30 @@ public class CoordELFunctions { /** * Determine the date-time in Oozie processing timezone of n-th future available dataset instance * from nominal Time but not beyond the instance specified as 'instance. - * <p/> + * <p> * It depends on: - * <p/> + * <p> * 1. Data set frequency - * <p/> + * <p> * 2. Data set Time unit (day, month, minute) - * <p/> + * <p> * 3. Data set Time zone/DST - * <p/> + * <p> * 4. End Day/Month flag - * <p/> + * <p> * 5. Data set initial instance - * <p/> + * <p> * 6. Action Creation Time - * <p/> + * <p> * 7. Existence of dataset's directory * * @param n :instance count - * <p/> - * domain: n >= 0, n is integer + * <p> + * domain: n >= 0, n is integer * @param instance: How many future instance it should check? value should - * be >=0 + * be >=0 * @return date-time in Oozie processing timezone of the n-th instance - * <p/> + * <p> * @throws Exception */ public static String ph3_coord_future(int n, int instance) throws Exception { @@ -252,34 +252,34 @@ public class CoordELFunctions { /** * Determine the date-time in Oozie processing timezone of the future available dataset instances * from start to end offsets from nominal Time but not beyond the instance specified as 'instance'. - * <p/> + * <p> * It depends on: - * <p/> + * <p> * 1. Data set frequency - * <p/> + * <p> * 2. Data set Time unit (day, month, minute) - * <p/> + * <p> * 3. Data set Time zone/DST - * <p/> + * <p> * 4. End Day/Month flag - * <p/> + * <p> * 5. Data set initial instance - * <p/> + * <p> * 6. Action Creation Time - * <p/> + * <p> * 7. Existence of dataset's directory * * @param start : start instance offset - * <p/> - * domain: start >= 0, start is integer + * <p> + * domain: start >= 0, start is integer * @param end : end instance offset - * <p/> - * domain: end >= 0, end is integer + * <p> + * domain: end >= 0, end is integer * @param instance: How many future instance it should check? value should - * be >=0 + * be >=0 * @return date-time in Oozie processing timezone of the instances from start to end offsets * delimited by comma. - * <p/> + * <p> * @throws Exception */ public static String ph3_coord_futureRange(int start, int end, int instance) throws Exception { @@ -396,7 +396,7 @@ public class CoordELFunctions { /** * Return nominal time or Action Creation Time. - * <p/> + * <p> * * @return coordinator action creation or materialization date time * @throws Exception if unable to format the Date object to String @@ -414,7 +414,7 @@ public class CoordELFunctions { /** * Convert from standard date-time formatting to a desired format. - * <p/> + * <p> * @param dateTimeStr - A timestamp in standard (ISO8601) format. * @param format - A string representing the desired format. * @return coordinator action creation or materialization date time @@ -432,7 +432,7 @@ public class CoordELFunctions { } /** - * Return Action Id. <p/> + * Return Action Id. <p> * * @return coordinator action Id */ @@ -448,7 +448,7 @@ public class CoordELFunctions { } /** - * Return Job Name. <p/> + * Return Job Name. <p> * * @return coordinator name */ @@ -464,7 +464,7 @@ public class CoordELFunctions { } /** - * Return Action Start time. <p/> + * Return Action Start time. <p> * * @return coordinator action start time * @throws Exception if unable to format the Date object to String @@ -483,14 +483,14 @@ public class CoordELFunctions { } /** - * Used to specify a list of URI's that are used as input dir to the workflow job. <p/> Look for two evaluator-level - * variables <p/> A) .datain.<DATAIN_NAME> B) .datain.<DATAIN_NAME>.unresolved <p/> A defines the current list of - * URI. <p/> B defines whether there are any unresolved EL-function (i.e latest) <p/> If there are something - * unresolved, this function will echo back the original function <p/> otherwise it sends the uris. + * Used to specify a list of URI's that are used as input dir to the workflow job. <p> Look for two evaluator-level + * variables <p> A) .datain.<DATAIN_NAME> B) .datain.<DATAIN_NAME>.unresolved <p> A defines the current list of + * URI. <p> B defines whether there are any unresolved EL-function (i.e latest) <p> If there are something + * unresolved, this function will echo back the original function <p> otherwise it sends the uris. * * @param dataInName : Datain name - * @return the list of URI's separated by INSTANCE_SEPARATOR <p/> if there are unresolved EL function (i.e. latest) - * , echo back <p/> the function without resolving the function. + * @return the list of URI's separated by INSTANCE_SEPARATOR <p> if there are unresolved EL function (i.e. latest) + * , echo back <p> the function without resolving the function. */ public static String ph3_coord_dataIn(String dataInName) { String uris = ""; @@ -504,8 +504,8 @@ public class CoordELFunctions { } /** - * Used to specify a list of URI's that are output dir of the workflow job. <p/> Look for one evaluator-level - * variable <p/> dataout.<DATAOUT_NAME> <p/> It defines the current list of URI. <p/> otherwise it sends the uris. + * Used to specify a list of URI's that are output dir of the workflow job. <p> Look for one evaluator-level + * variable <p> dataout.<DATAOUT_NAME> <p> It defines the current list of URI. <p> otherwise it sends the uris. * * @param dataOutName : Dataout name * @return the list of URI's separated by INSTANCE_SEPARATOR @@ -518,10 +518,10 @@ public class CoordELFunctions { } /** - * Determine the date-time in Oozie processing timezone of n-th dataset instance. <p/> It depends on: <p/> 1. - * Data set frequency <p/> 2. - * Data set Time unit (day, month, minute) <p/> 3. Data set Time zone/DST <p/> 4. End Day/Month flag <p/> 5. Data - * set initial instance <p/> 6. Action Creation Time + * Determine the date-time in Oozie processing timezone of n-th dataset instance. <p> It depends on: <p> 1. + * Data set frequency <p> 2. + * Data set Time unit (day, month, minute) <p> 3. Data set Time zone/DST <p> 4. End Day/Month flag <p> 5. Data + * set initial instance <p> 6. Action Creation Time * * @param n instance count domain: n is integer * @return date-time in Oozie processing timezone of the n-th instance returns 'null' means n-th instance is @@ -539,14 +539,14 @@ public class CoordELFunctions { /** * Determine the date-time in Oozie processing timezone of current dataset instances - * from start to end offsets from the nominal time. <p/> It depends - * on: <p/> 1. Data set frequency <p/> 2. Data set Time unit (day, month, minute) <p/> 3. Data set Time zone/DST - * <p/> 4. End Day/Month flag <p/> 5. Data set initial instance <p/> 6. Action Creation Time + * from start to end offsets from the nominal time. <p> It depends + * on: <p> 1. Data set frequency <p> 2. Data set Time unit (day, month, minute) <p> 3. Data set Time zone/DST + * <p> 4. End Day/Month flag <p> 5. Data set initial instance <p> 6. Action Creation Time * - * @param start :start instance offset <p/> domain: start <= 0, start is integer - * @param end :end instance offset <p/> domain: end <= 0, end is integer + * @param start :start instance offset <p> domain: start <= 0, start is integer + * @param end :end instance offset <p> domain: end <= 0, end is integer * @return date-time in Oozie processing timezone of the instances from start to end offsets - * delimited by comma. <p/> If the current instance time of the dataset based on the Action Creation Time + * delimited by comma. <p> If the current instance time of the dataset based on the Action Creation Time * is earlier than the Initial-Instance of DS an empty string is returned. * If an instance within the range is earlier than Initial-Instance of DS that instance is ignored * @throws Exception @@ -560,9 +560,9 @@ public class CoordELFunctions { } } /** - * Determine the date-time in Oozie processing timezone of the given offset from the dataset effective nominal time. <p/> It - * depends on: <p> 1. Data set frequency <p/> 2. Data set Time Unit <p/> 3. Data set Time zone/DST - * <p/> 4. Data set initial instance <p/> 5. Action Creation Time + * Determine the date-time in Oozie processing timezone of the given offset from the dataset effective nominal time. <p> It + * depends on: <p> 1. Data set frequency <p> 2. Data set Time Unit <p> 3. Data set Time zone/DST + * <p> 4. Data set initial instance <p> 5. Action Creation Time * * @param n offset amount (integer) * @param timeUnit TimeUnit for offset n ("MINUTE", "HOUR", "DAY", "MONTH", "YEAR") @@ -579,12 +579,12 @@ public class CoordELFunctions { } /** - * Determine how many hours is on the date of n-th dataset instance. <p/> It depends on: <p/> 1. Data set frequency - * <p/> 2. Data set Time unit (day, month, minute) <p/> 3. Data set Time zone/DST <p/> 4. End Day/Month flag <p/> 5. - * Data set initial instance <p/> 6. Action Creation Time + * Determine how many hours is on the date of n-th dataset instance. <p> It depends on: <p> 1. Data set frequency + * <p> 2. Data set Time unit (day, month, minute) <p> 3. Data set Time zone/DST <p> 4. End Day/Month flag <p> 5. + * Data set initial instance <p> 6. Action Creation Time * - * @param n instance count <p/> domain: n is integer - * @return number of hours on that day <p/> returns -1 means n-th instance is earlier than Initial-Instance of DS + * @param n instance count <p> domain: n is integer + * @return number of hours on that day <p> returns -1 means n-th instance is earlier than Initial-Instance of DS * @throws Exception */ public static int ph2_coord_hoursInDay(int n) throws Exception { @@ -610,12 +610,12 @@ public class CoordELFunctions { } /** - * Calculate number of days in one month for n-th dataset instance. <p/> It depends on: <p/> 1. Data set frequency . - * <p/> 2. Data set Time unit (day, month, minute) <p/> 3. Data set Time zone/DST <p/> 4. End Day/Month flag <p/> 5. - * Data set initial instance <p/> 6. Action Creation Time + * Calculate number of days in one month for n-th dataset instance. <p> It depends on: <p> 1. Data set frequency . + * <p> 2. Data set Time unit (day, month, minute) <p> 3. Data set Time zone/DST <p> 4. End Day/Month flag <p> 5. + * Data set initial instance <p> 6. Action Creation Time * * @param n instance count. domain: n is integer - * @return number of days in that month <p/> returns -1 means n-th instance is earlier than Initial-Instance of DS + * @return number of days in that month <p> returns -1 means n-th instance is earlier than Initial-Instance of DS * @throws Exception */ public static int ph2_coord_daysInMonth(int n) throws Exception { @@ -641,13 +641,13 @@ public class CoordELFunctions { } /** - * Determine the date-time in Oozie processing timezone of n-th latest available dataset instance. <p/> It depends - * on: <p/> 1. Data set frequency <p/> 2. Data set Time unit (day, month, minute) <p/> 3. Data set Time zone/DST - * <p/> 4. End Day/Month flag <p/> 5. Data set initial instance <p/> 6. Action Creation Time <p/> 7. Existence of + * Determine the date-time in Oozie processing timezone of n-th latest available dataset instance. <p> It depends + * on: <p> 1. Data set frequency <p> 2. Data set Time unit (day, month, minute) <p> 3. Data set Time zone/DST + * <p> 4. End Day/Month flag <p> 5. Data set initial instance <p> 6. Action Creation Time <p> 7. Existence of * dataset's directory * - * @param n :instance count <p/> domain: n <= 0, n is integer - * @return date-time in Oozie processing timezone of the n-th instance <p/> returns 'null' means n-th instance is + * @param n :instance count <p> domain: n <= 0, n is integer + * @return date-time in Oozie processing timezone of the n-th instance <p> returns 'null' means n-th instance is * earlier than Initial-Instance of DS * @throws Exception */ @@ -663,15 +663,15 @@ public class CoordELFunctions { /** * Determine the date-time in Oozie processing timezone of latest available dataset instances - * from start to end offsets from the nominal time. <p/> It depends - * on: <p/> 1. Data set frequency <p/> 2. Data set Time unit (day, month, minute) <p/> 3. Data set Time zone/DST - * <p/> 4. End Day/Month flag <p/> 5. Data set initial instance <p/> 6. Action Creation Time <p/> 7. Existence of + * from start to end offsets from the nominal time. <p> It depends + * on: <p> 1. Data set frequency <p> 2. Data set Time unit (day, month, minute) <p> 3. Data set Time zone/DST + * <p> 4. End Day/Month flag <p> 5. Data set initial instance <p> 6. Action Creation Time <p> 7. Existence of * dataset's directory * - * @param start :start instance offset <p/> domain: start <= 0, start is integer - * @param end :end instance offset <p/> domain: end <= 0, end is integer + * @param start :start instance offset <p> domain: start <= 0, start is integer + * @param end :end instance offset <p> domain: end <= 0, end is integer * @return date-time in Oozie processing timezone of the instances from start to end offsets - * delimited by comma. <p/> returns 'null' means start offset instance is + * delimited by comma. <p> returns 'null' means start offset instance is * earlier than Initial-Instance of DS * @throws Exception */ @@ -687,7 +687,7 @@ public class CoordELFunctions { } /** - * Configure an evaluator with data set and application specific information. <p/> Helper method of associating + * Configure an evaluator with data set and application specific information. <p> Helper method of associating * dataset and application object * * @param evaluator : to set variables @@ -700,7 +700,7 @@ public class CoordELFunctions { } /** - * Helper method to wrap around with "${..}". <p/> + * Helper method to wrap around with "${..}". <p> * * * @param eval :EL evaluator @@ -943,8 +943,8 @@ public class CoordELFunctions { // Local methods /** * @param n - * @return n-th instance Date-Time from current instance for data-set <p/> return empty string ("") if the - * Action_Creation_time or the n-th instance <p/> is earlier than the Initial_Instance of dataset. + * @return n-th instance Date-Time from current instance for data-set <p> return empty string ("") if the + * Action_Creation_time or the n-th instance <p> is earlier than the Initial_Instance of dataset. * @throws Exception */ private static String coord_current_sync(int n) throws Exception { @@ -989,8 +989,8 @@ public class CoordELFunctions { * * @param n offset amount (integer) * @param timeUnit TimeUnit for offset n ("MINUTE", "HOUR", "DAY", "MONTH", "YEAR") - * @return the offset time from the effective nominal time <p/> return empty string ("") if the Action_Creation_time or the - * offset instance <p/> is earlier than the Initial_Instance of dataset. + * @return the offset time from the effective nominal time <p> return empty string ("") if the Action_Creation_time or the + * offset instance <p> is earlier than the Initial_Instance of dataset. * @throws Exception */ private static String coord_offset_sync(int n, String timeUnit) throws Exception { http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/coord/CoordinatorJobException.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/coord/CoordinatorJobException.java b/core/src/main/java/org/apache/oozie/coord/CoordinatorJobException.java index 62bda4b..8610e2a 100644 --- a/core/src/main/java/org/apache/oozie/coord/CoordinatorJobException.java +++ b/core/src/main/java/org/apache/oozie/coord/CoordinatorJobException.java @@ -23,7 +23,7 @@ import org.apache.oozie.XException; import org.apache.oozie.util.XLog; /** - * Exception thrown by {@link org.apache.oozie.client.CoordintorJob} . + * Exception thrown by {@link org.apache.oozie.client.CoordinatorJob}. */ public class CoordinatorJobException extends XException { http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java b/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java index f99b87a..9475f72 100644 --- a/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java +++ b/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java @@ -68,10 +68,10 @@ public class HCatELFunctions { * @param dataInName * @return the same EL function */ - public static String ph1_coord_databaseIn_echo(String dataName) { + public static String ph1_coord_databaseIn_echo(String dataInName) { // Checking if the dataIn is correct? - isValidDataEvent(dataName); - return echoUnResolved("databaseIn", "'" + dataName + "'"); + isValidDataEvent(dataInName); + return echoUnResolved("databaseIn", "'" + dataInName + "'"); } public static String ph1_coord_databaseOut_echo(String dataName) { @@ -137,8 +137,8 @@ public class HCatELFunctions { * @param dataInName * @return DB name */ - public static String ph3_coord_databaseIn(String dataName) { - HCatURI hcatURI = getURIFromResolved(dataName, EventType.input); + public static String ph3_coord_databaseIn(String dataInName) { + HCatURI hcatURI = getURIFromResolved(dataInName, EventType.input); if (hcatURI != null) { return hcatURI.getDb(); } @@ -156,8 +156,8 @@ public class HCatELFunctions { * @param dataOutName * @return DB name */ - public static String ph3_coord_databaseOut(String dataName) { - HCatURI hcatURI = getURIFromResolved(dataName, EventType.output); + public static String ph3_coord_databaseOut(String dataOutName) { + HCatURI hcatURI = getURIFromResolved(dataOutName, EventType.output); if (hcatURI != null) { return hcatURI.getDb(); } @@ -175,8 +175,8 @@ public class HCatELFunctions { * @param dataInName * @return Table name */ - public static String ph3_coord_tableIn(String dataName) { - HCatURI hcatURI = getURIFromResolved(dataName, EventType.input); + public static String ph3_coord_tableIn(String dataInName) { + HCatURI hcatURI = getURIFromResolved(dataInName, EventType.input); if (hcatURI != null) { return hcatURI.getTable(); } @@ -194,8 +194,8 @@ public class HCatELFunctions { * @param dataOutName * @return Table name */ - public static String ph3_coord_tableOut(String dataName) { - HCatURI hcatURI = getURIFromResolved(dataName, EventType.output); + public static String ph3_coord_tableOut(String dataOutName) { + HCatURI hcatURI = getURIFromResolved(dataOutName, EventType.output); if (hcatURI != null) { return hcatURI.getTable(); } @@ -205,10 +205,10 @@ public class HCatELFunctions { } /** - * Used to specify the HCat partition filter which is input dependency for workflow job.<p/> Look for two evaluator-level - * variables <p/> A) .datain.<DATAIN_NAME> B) .datain.<DATAIN_NAME>.unresolved <p/> A defines the current list of - * HCat URIs. <p/> B defines whether there are any unresolved EL-function (i.e latest) <p/> If there are something - * unresolved, this function will echo back the original function <p/> otherwise it sends the partition filter. + * Used to specify the HCat partition filter which is input dependency for workflow job.<p> Look for two evaluator-level + * variables <p> A) .datain.<DATAIN_NAME> B) .datain.<DATAIN_NAME>.unresolved <p> A defines the current list of + * HCat URIs. <p> B defines whether there are any unresolved EL-function (i.e latest) <p> If there are something + * unresolved, this function will echo back the original function <p> otherwise it sends the partition filter. * * @param dataInName : Datain name * @param type : for action type - pig, MR or hive @@ -224,10 +224,10 @@ public class HCatELFunctions { } /** - * Used to specify the HCat partition's value defining output for workflow job.<p/> Look for two evaluator-level - * variables <p/> A) .dataout.<DATAOUT_NAME> B) .dataout.<DATAOUT_NAME>.unresolved <p/> A defines the current list of - * HCat URIs. <p/> B defines whether there are any unresolved EL-function (i.e latest) <p/> If there are something - * unresolved, this function will echo back the original function <p/> otherwise it sends the partition value. + * Used to specify the HCat partition's value defining output for workflow job.<p> Look for two evaluator-level + * variables <p> A) .dataout.<DATAOUT_NAME> B) .dataout.<DATAOUT_NAME>.unresolved <p> A defines the current list of + * HCat URIs. <p> B defines whether there are any unresolved EL-function (i.e latest) <p> If there are something + * unresolved, this function will echo back the original function <p> otherwise it sends the partition value. * * @param dataOutName : Dataout name * @param partitionName : Specific partition name whose value is wanted @@ -250,10 +250,10 @@ public class HCatELFunctions { } /** - * Used to specify the entire HCat partition defining output for workflow job.<p/> Look for two evaluator-level - * variables <p/> A) .dataout.<DATAOUT_NAME> B) .dataout.<DATAOUT_NAME>.unresolved <p/> A defines the data-out - * HCat URI. <p/> B defines whether there are any unresolved EL-function (i.e latest) <p/> If there are something - * unresolved, this function will echo back the original function <p/> otherwise it sends the partition. + * Used to specify the entire HCat partition defining output for workflow job.<p> Look for two evaluator-level + * variables <p> A) .dataout.<DATAOUT_NAME> B) .dataout.<DATAOUT_NAME>.unresolved <p> A defines the data-out + * HCat URI. <p> B defines whether there are any unresolved EL-function (i.e latest) <p> If there are something + * unresolved, this function will echo back the original function <p> otherwise it sends the partition. * * @param dataOutName : DataOut name */ @@ -273,10 +273,10 @@ public class HCatELFunctions { } /** - * Used to specify the entire HCat partition defining input for workflow job. <p/> Look for two evaluator-level - * variables <p/> A) .datain.<DATAIN_NAME> B) .datain.<DATAIN_NAME>.unresolved <p/> A defines the data-in HCat URI. - * <p/> B defines whether there are any unresolved EL-function (i.e latest) <p/> If there are something unresolved, - * this function will echo back the original function <p/> otherwise it sends the partition. + * Used to specify the entire HCat partition defining input for workflow job. <p> Look for two evaluator-level + * variables <p> A) .datain.<DATAIN_NAME> B) .datain.<DATAIN_NAME>.unresolved <p> A defines the data-in HCat URI. + * <p> B defines whether there are any unresolved EL-function (i.e latest) <p> If there are something unresolved, + * this function will echo back the original function <p> otherwise it sends the partition. * * @param dataInName : DataIn name * @param type : for action type: hive-export @@ -314,10 +314,10 @@ public class HCatELFunctions { } /** - * Used to specify the MAXIMUM value of an HCat partition which is input dependency for workflow job.<p/> Look for two evaluator-level - * variables <p/> A) .datain.<DATAIN_NAME> B) .datain.<DATAIN_NAME>.unresolved <p/> A defines the current list of - * HCat URIs. <p/> B defines whether there are any unresolved EL-function (i.e latest) <p/> If there are something - * unresolved, this function will echo back the original function <p/> otherwise it sends the max partition value. + * Used to specify the MAXIMUM value of an HCat partition which is input dependency for workflow job.<p> Look for two evaluator-level + * variables <p> A) .datain.<DATAIN_NAME> B) .datain.<DATAIN_NAME>.unresolved <p> A defines the current list of + * HCat URIs. <p> B defines whether there are any unresolved EL-function (i.e latest) <p> If there are something + * unresolved, this function will echo back the original function <p> otherwise it sends the max partition value. * * @param dataInName : Datain name * @param partitionName : Specific partition name whose MAX value is wanted @@ -359,10 +359,10 @@ public class HCatELFunctions { } /** - * Used to specify the MINIMUM value of an HCat partition which is input dependency for workflow job.<p/> Look for two evaluator-level - * variables <p/> A) .datain.<DATAIN_NAME> B) .datain.<DATAIN_NAME>.unresolved <p/> A defines the current list of - * HCat URIs. <p/> B defines whether there are any unresolved EL-function (i.e latest) <p/> If there are something - * unresolved, this function will echo back the original function <p/> otherwise it sends the min partition value. + * Used to specify the MINIMUM value of an HCat partition which is input dependency for workflow job.<p> Look for two evaluator-level + * variables <p> A) .datain.<DATAIN_NAME> B) .datain.<DATAIN_NAME>.unresolved <p> A defines the current list of + * HCat URIs. <p> B defines whether there are any unresolved EL-function (i.e latest) <p> If there are something + * unresolved, this function will echo back the original function <p> otherwise it sends the min partition value. * * @param dataInName : Datain name * @param partitionName : Specific partition name whose MIN value is wanted http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/coord/SyncCoordDataset.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/coord/SyncCoordDataset.java b/core/src/main/java/org/apache/oozie/coord/SyncCoordDataset.java index 71b1ec5..370015a 100644 --- a/core/src/main/java/org/apache/oozie/coord/SyncCoordDataset.java +++ b/core/src/main/java/org/apache/oozie/coord/SyncCoordDataset.java @@ -43,7 +43,7 @@ public class SyncCoordDataset { } /** - * @param name the name to set + * @param doneFlag the name to set */ public void setDoneFlag(String doneFlag) { this.doneFlag = doneFlag; http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/dependency/URIHandler.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/dependency/URIHandler.java b/core/src/main/java/org/apache/oozie/dependency/URIHandler.java index 6e54d4b..bc94716 100644 --- a/core/src/main/java/org/apache/oozie/dependency/URIHandler.java +++ b/core/src/main/java/org/apache/oozie/dependency/URIHandler.java @@ -92,8 +92,6 @@ public interface URIHandler { * * @param uri The URI to be removed from missing dependency * @param actionID The id of action which was dependent on the uri. - * - * @throws URIHandlerException */ public boolean unregisterFromNotification(URI uri, String actionID); @@ -173,7 +171,6 @@ public interface URIHandler { /** * Check whether the URI is valid or not * @param uri - * @return * @throws URIHandlerException */ public void validate(String uri) throws URIHandlerException; http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/event/EventQueue.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/event/EventQueue.java b/core/src/main/java/org/apache/oozie/event/EventQueue.java index 9ef6dfa..6dbf8c5 100644 --- a/core/src/main/java/org/apache/oozie/event/EventQueue.java +++ b/core/src/main/java/org/apache/oozie/event/EventQueue.java @@ -47,7 +47,7 @@ public interface EventQueue { /** * Add event to queue - * @param event + * @param e */ public void add(Event e); http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java b/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java index ced210a..e98d10a 100644 --- a/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java +++ b/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java @@ -44,31 +44,31 @@ public abstract class JobEventListener { /** * On workflow job transition - * @param WorkflowJobEvent + * @param wje */ public abstract void onWorkflowJobEvent(WorkflowJobEvent wje); /** * On workflow action transition - * @param WorkflowActionEvent + * @param wae */ public abstract void onWorkflowActionEvent(WorkflowActionEvent wae); /** * On coordinator job transition - * @param CoordinatorJobEvent + * @param cje */ public abstract void onCoordinatorJobEvent(CoordinatorJobEvent cje); /** * On coordinator action transition - * @param CoordinatorActionEvent + * @param cae */ public abstract void onCoordinatorActionEvent(CoordinatorActionEvent cae); /** * On bundle job transition - * @param BundleJobEvent + * @param bje */ public abstract void onBundleJobEvent(BundleJobEvent bje); http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java b/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java index 1477e54..54cc9d8 100644 --- a/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java +++ b/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java @@ -48,8 +48,7 @@ import org.apache.oozie.util.DateUtils; import org.apache.oozie.util.ParamChecker; /** - * The query executor class for bulk monitoring queries i.e. debugging bundle -> - * coord actions directly + * The query executor class for bulk monitoring queries i.e. debugging bundle coord actions directly */ public class BulkJPAExecutor implements JPAExecutor<BulkResponseInfo> { private Map<String, List<String>> bulkFilter; http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java b/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java index 91c625c..02a4f68 100644 --- a/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java +++ b/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java @@ -35,7 +35,7 @@ public class CoordActionRemoveJPAExecutor implements JPAExecutor<Void> { /** * Constructor which records coordinator action id. * - * @param coordAction + * @param coordActionId */ public CoordActionRemoveJPAExecutor(String coordActionId) { ParamChecker.notNull(coordActionId, "coordActionId"); http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/executor/jpa/JPAExecutor.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/executor/jpa/JPAExecutor.java b/core/src/main/java/org/apache/oozie/executor/jpa/JPAExecutor.java index 0b25a36..f3b71af 100644 --- a/core/src/main/java/org/apache/oozie/executor/jpa/JPAExecutor.java +++ b/core/src/main/java/org/apache/oozie/executor/jpa/JPAExecutor.java @@ -22,7 +22,7 @@ import javax.persistence.EntityManager; /** * Executor pattern interface that gives access to an {@link EntityManager}. - * <p/> + * <p> * Implementations are executed by the {@link org.apache.oozie.service.JPAService}. */ public interface JPAExecutor<T> { @@ -36,9 +36,9 @@ public interface JPAExecutor<T> { /** * Method that encapsulates JPA access operations. - * <p/> + * <p> * Implementations should not close the received {@link EntityManager}. - * <p/> + * <p> * Implementations should commit any transaction before ending, else the transaction will be rolled back. * * @param em an active {@link EntityManager} http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java b/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java index 1c748c3..a07edfa 100644 --- a/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java +++ b/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java @@ -96,8 +96,7 @@ public interface ConnectionContext { /** * Creates a threadlocal session using session opts * - * @param session - * @param topicName + * @param sessionOpts * @return * @throws JMSException */ http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/local/LocalOozie.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/local/LocalOozie.java b/core/src/main/java/org/apache/oozie/local/LocalOozie.java index f99efea..bf1b0db 100644 --- a/core/src/main/java/org/apache/oozie/local/LocalOozie.java +++ b/core/src/main/java/org/apache/oozie/local/LocalOozie.java @@ -34,7 +34,7 @@ import org.apache.oozie.util.ParamChecker; import org.apache.oozie.util.XLog; /** - * LocalOozie runs workflows in an embedded Oozie instance . <p/> LocalOozie is meant for development/debugging purposes + * LocalOozie runs workflows in an embedded Oozie instance . <p> LocalOozie is meant for development/debugging purposes * only. */ public class LocalOozie { @@ -114,12 +114,12 @@ public class LocalOozie { } /** - * Return a {@link org.apache.oozie.client.OozieClient} for LocalOozie. <p/> The returned instance is configured - * with the user name of the JVM (the value of the system property 'user.name'). <p/> The following methods of the + * Return a {@link org.apache.oozie.client.OozieClient} for LocalOozie. <p> The returned instance is configured + * with the user name of the JVM (the value of the system property 'user.name'). <p> The following methods of the * client are NOP in the returned instance: {@link org.apache.oozie.client.OozieClient#validateWSVersion}, {@link * org.apache.oozie.client.OozieClient#setHeader}, {@link org.apache.oozie.client.OozieClient#getHeader}, {@link * org.apache.oozie.client.OozieClient#removeHeader}, {@link org.apache.oozie.client.OozieClient#getHeaderNames} and - * {@link org.apache.oozie.client.OozieClient#setSafeMode}. + * {@link org.apache.oozie.client.OozieClient#setSystemMode(OozieClient.SYSTEM_MODE)}. * * @return a {@link org.apache.oozie.client.OozieClient} for LocalOozie. */ @@ -129,17 +129,17 @@ public class LocalOozie { /** * Return a {@link org.apache.oozie.client.OozieClient} for LocalOozie. - * <p/> + * <p> * The returned instance is configured with the user name of the JVM (the * value of the system property 'user.name'). - * <p/> + * <p> * The following methods of the client are NOP in the returned instance: * {@link org.apache.oozie.client.OozieClient#validateWSVersion}, * {@link org.apache.oozie.client.OozieClient#setHeader}, * {@link org.apache.oozie.client.OozieClient#getHeader}, * {@link org.apache.oozie.client.OozieClient#removeHeader}, * {@link org.apache.oozie.client.OozieClient#getHeaderNames} and - * {@link org.apache.oozie.client.OozieClient#setSafeMode}. + * {@link org.apache.oozie.client.OozieClient#setSystemMode(OozieClient.SYSTEM_MODE)}. * * @return a {@link org.apache.oozie.client.OozieClient} for LocalOozie. */ @@ -149,10 +149,12 @@ public class LocalOozie { /** * Return a {@link org.apache.oozie.client.OozieClient} for LocalOozie configured for a given user. - * <p/> - * The following methods of the client are NOP in the returned instance: {@link org.apache.oozie.client.OozieClient#validateWSVersion}, - * {@link org.apache.oozie.client.OozieClient#setHeader}, {@link org.apache.oozie.client.OozieClient#getHeader}, {@link org.apache.oozie.client.OozieClient#removeHeader}, - * {@link org.apache.oozie.client.OozieClient#getHeaderNames} and {@link org.apache.oozie.client.OozieClient#setSafeMode}. + * <p> + * The following methods of the client are NOP in the returned instance: + * {@link org.apache.oozie.client.OozieClient#validateWSVersion}, {@link org.apache.oozie.client.OozieClient#setHeader}, + * {@link org.apache.oozie.client.OozieClient#getHeader}, {@link org.apache.oozie.client.OozieClient#removeHeader}, + * {@link org.apache.oozie.client.OozieClient#getHeaderNames} + * and {@link org.apache.oozie.client.OozieClient#setSystemMode(OozieClient.SYSTEM_MODE)}. * * @param user user name to use in LocalOozie for running workflows. * @return a {@link org.apache.oozie.client.OozieClient} for LocalOozie configured for the given user. @@ -169,14 +171,14 @@ public class LocalOozie { /** * Return a {@link org.apache.oozie.client.OozieClient} for LocalOozie * configured for a given user. - * <p/> + * <p> * The following methods of the client are NOP in the returned instance: * {@link org.apache.oozie.client.OozieClient#validateWSVersion}, * {@link org.apache.oozie.client.OozieClient#setHeader}, * {@link org.apache.oozie.client.OozieClient#getHeader}, * {@link org.apache.oozie.client.OozieClient#removeHeader}, * {@link org.apache.oozie.client.OozieClient#getHeaderNames} and - * {@link org.apache.oozie.client.OozieClient#setSafeMode}. + * {@link org.apache.oozie.client.OozieClient#setSystemMode(OozieClient.SYSTEM_MODE)}. * * @param user user name to use in LocalOozie for running coordinator. * @return a {@link org.apache.oozie.client.OozieClient} for LocalOozie http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java b/core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java index 99cf76b..b224d82 100644 --- a/core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java +++ b/core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java @@ -38,8 +38,8 @@ import com.google.common.annotations.VisibleForTesting; /** * The Abandoned Coord Checker Service check finds out the abandoned coord jobs in system and kills it. A job is - * considered to be abandoned/faulty if total number of actions in failed/timedout/suspended >= limit and there are no - * succeeded action and job start time < job.older.than. Email will not be sent if + * considered to be abandoned/faulty if total number of actions in failed/timedout/suspended >= limit and there are no + * succeeded action and job start time < job.older.than. Email will not be sent if * oozie.service.AbandonedCoordCheckerService.email.address is not configured. */ public class AbandonedCoordCheckerService implements Service { http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/AuthorizationService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/AuthorizationService.java b/core/src/main/java/org/apache/oozie/service/AuthorizationService.java index cd2372e..f281873 100644 --- a/core/src/main/java/org/apache/oozie/service/AuthorizationService.java +++ b/core/src/main/java/org/apache/oozie/service/AuthorizationService.java @@ -102,7 +102,7 @@ public class AuthorizationService implements Service { } /** - * Initialize the service. <p/> Reads the security related configuration. parameters - security enabled and list of + * Initialize the service. <p> Reads the security related configuration. parameters - security enabled and list of * super users. * * @param services services instance. @@ -198,7 +198,7 @@ public class AuthorizationService implements Service { } /** - * Destroy the service. <p/> This implementation does a NOP. + * Destroy the service. <p> This implementation does a NOP. */ public void destroy() { } @@ -231,7 +231,7 @@ public class AuthorizationService implements Service { } /** - * Check if the user belongs to the group or not. <p/> <p/> Subclasses should override the {@link #isUserInGroup} + * Check if the user belongs to the group or not. <p> <p> Subclasses should override the {@link #isUserInGroup} * method. * * @param user user name. @@ -246,7 +246,7 @@ public class AuthorizationService implements Service { } /** - * Return the default group to which the user belongs. <p/> This implementation always returns 'users'. + * Return the default group to which the user belongs. <p> This implementation always returns 'users'. * * @param user user name. * @return default group of user. @@ -262,7 +262,7 @@ public class AuthorizationService implements Service { } /** - * Check if the user has admin privileges. <p/> If admin is disabled it returns always <code>true</code>. <p/> If + * Check if the user has admin privileges. <p> If admin is disabled it returns always <code>true</code>. <p> If * admin is enabled it returns <code>true</code> if the user is in the <code>adminusers.txt</code> file. * * @param user user name. @@ -291,7 +291,7 @@ public class AuthorizationService implements Service { } /** - * Check if the user has admin privileges. <p/> Subclasses should override the {@link #isUserInGroup} method. + * Check if the user has admin privileges. <p> Subclasses should override the {@link #isUserInGroup} method. * * @param user user name. * @param write indicates if the check is for read or write admin tasks (in this implementation this is ignored) @@ -305,7 +305,7 @@ public class AuthorizationService implements Service { } /** - * Check if the user+group is authorized to use the specified application. <p/> The check is done by checking the + * Check if the user+group is authorized to use the specified application. <p> The check is done by checking the * file system permissions on the workflow application. * * @param user user name. @@ -355,7 +355,7 @@ public class AuthorizationService implements Service { } /** - * Check if the user+group is authorized to use the specified application. <p/> The check is done by checking the + * Check if the user+group is authorized to use the specified application. <p> The check is done by checking the * file system permissions on the workflow application. * * @param user user name. @@ -424,8 +424,8 @@ public class AuthorizationService implements Service { } /** - * Check if the user+group is authorized to operate on the specified job. <p/> Checks if the user is a super-user or - * the one who started the job. <p/> Read operations are allowed to all users. + * Check if the user+group is authorized to operate on the specified job. <p> Checks if the user is a super-user or + * the one who started the job. <p> Read operations are allowed to all users. * * @param user user name. * @param jobId job id. @@ -509,8 +509,8 @@ public class AuthorizationService implements Service { } /** - * Check if the user+group is authorized to operate on the specified jobs. <p/> Checks if the user is a super-user or - * the one who started the jobs. <p/> Read operations are allowed to all users. + * Check if the user+group is authorized to operate on the specified jobs. <p> Checks if the user is a super-user or + * the one who started the jobs. <p> Read operations are allowed to all users. * * @param user user name. * @param filter filter used to select jobs http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/CallableQueueService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/CallableQueueService.java b/core/src/main/java/org/apache/oozie/service/CallableQueueService.java index fd7b55f..830a58e 100644 --- a/core/src/main/java/org/apache/oozie/service/CallableQueueService.java +++ b/core/src/main/java/org/apache/oozie/service/CallableQueueService.java @@ -47,20 +47,20 @@ import org.apache.oozie.util.PriorityDelayQueue.QueueElement; /** * The callable queue service queues {@link XCallable}s for asynchronous execution. - * <p/> + * <p> * Callables can be queued for immediate execution or for delayed execution (some time in the future). - * <p/> + * <p> * Callables are consumed from the queue for execution based on their priority. - * <p/> + * <p> * When the queues (for immediate execution and for delayed execution) are full, the callable queue service stops * queuing callables. - * <p/> + * <p> * A thread-pool is used to execute the callables asynchronously. - * <p/> + * <p> * The following configuration parameters control the callable queue service: - * <p/> + * <p> * {@link #CONF_QUEUE_SIZE} size of the immediate execution queue. Defaulf value is 10000. - * <p/> + * <p> * {@link #CONF_THREADS} number of threads in the thread-pool used for asynchronous command execution. When this number * of threads is reached, commands remain the queue until threads become available. Sets up a priority queue for the * execution of Commands via a ThreadPool. Sets up a Delayed Queue to handle actions which will be ready for execution @@ -203,9 +203,9 @@ public class CallableQueueService implements Service, Instrumentable { /** * Filter the duplicate callables from the list before queue this. - * <p/> + * <p> * If it is single callable, checking if key is in unique map or not. - * <p/> + * <p> * If it is composite callable, remove duplicates callables from the composite. * * @return true if this callable should be queued @@ -591,9 +591,9 @@ public class CallableQueueService implements Service, Instrumentable { /** * Queue a list of callables for serial execution. - * <p/> + * <p> * Useful to serialize callables that may compete with each other for resources. - * <p/> + * <p> * All callables will be processed with the priority of the highest priority of all callables. * * @param callables callables to be executed by the composite callable. @@ -635,9 +635,9 @@ public class CallableQueueService implements Service, Instrumentable { /** * Queue a list of callables for serial execution sometime in the future. - * <p/> + * <p> * Useful to serialize callables that may compete with each other for resources. - * <p/> + * <p> * All callables will be processed with the priority of the highest priority of all callables. * * @param callables callables to be executed by the composite callable. http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/ConfigurationService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/ConfigurationService.java b/core/src/main/java/org/apache/oozie/service/ConfigurationService.java index d602e53..93a7326 100644 --- a/core/src/main/java/org/apache/oozie/service/ConfigurationService.java +++ b/core/src/main/java/org/apache/oozie/service/ConfigurationService.java @@ -43,23 +43,23 @@ import com.google.common.annotations.VisibleForTesting; /** * Built in service that initializes the services configuration. - * <p/> + * <p> * The configuration loading sequence is identical to Hadoop configuration loading sequence. - * <p/> + * <p> * Default values are loaded from the 'oozie-default.xml' file from the classpath, then site configured values * are loaded from a site configuration file from the Oozie configuration directory. - * <p/> - * The Oozie configuration directory is resolved using the <code>OOZIE_HOME<code> environment variable as - * <code>${OOZIE_HOME}/conf</code>. If the <code>OOZIE_HOME<code> environment variable is not defined the + * <p> + * The Oozie configuration directory is resolved using the <code>OOZIE_HOME</code> environment variable as + * <code>${OOZIE_HOME}/conf</code>. If the <code>OOZIE_HOME</code> environment variable is not defined the * initialization of the <code>ConfigurationService</code> fails. - * <p/> + * <p> * The site configuration is loaded from the <code>oozie-site.xml</code> file in the configuration directory. - * <p/> + * <p> * The site configuration file name to use can be changed by setting the <code>OOZIE_CONFIG_FILE</code> environment * variable to an alternate file name. The alternate file must ber in the Oozie configuration directory. - * <p/> + * <p> * Configuration properties, prefixed with 'oozie.', passed as system properties overrides default and site values. - * <p/> + * <p> * The configuration service logs details on how the configuration was loaded as well as what properties were overrode * via system properties settings. */ @@ -396,7 +396,7 @@ public class ConfigurationService implements Service, Instrumentable { } /** - * Instruments the configuration service. <p/> It sets instrumentation variables indicating the config dir and + * Instruments the configuration service. <p> It sets instrumentation variables indicating the config dir and * config file used. * * @param instr instrumentation to use. http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/ELService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/ELService.java b/core/src/main/java/org/apache/oozie/service/ELService.java index 2506e99..d27d47f 100644 --- a/core/src/main/java/org/apache/oozie/service/ELService.java +++ b/core/src/main/java/org/apache/oozie/service/ELService.java @@ -32,10 +32,10 @@ import java.util.List; /** * The ELService creates {@link ELEvaluator} instances preconfigured with constants and functions defined in the - * configuration. <p/> The following configuration parameters control the EL service: <p/> {@link #CONF_CONSTANTS} list - * of constant definitions to be available for EL evaluations. <p/> {@link #CONF_FUNCTIONS} list of function definitions - * to be available for EL evalations. <p/> Definitions must be separated by a comma, definitions are trimmed. <p/> The - * syntax for a constant definition is <code>PREFIX:NAME=CLASS_NAME#CONSTANT_NAME</code>. <p/> The syntax for a constant + * configuration. <p> The following configuration parameters control the EL service: <p> {@link #CONF_CONSTANTS} list + * of constant definitions to be available for EL evaluations. <p> {@link #CONF_FUNCTIONS} list of function definitions + * to be available for EL evalations. <p> Definitions must be separated by a comma, definitions are trimmed. <p> The + * syntax for a constant definition is <code>PREFIX:NAME=CLASS_NAME#CONSTANT_NAME</code>. <p> The syntax for a constant * definition is <code>PREFIX:NAME=CLASS_NAME#METHOD_NAME</code>. */ public class ELService implements Service { http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java b/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java index 6a3f045..b72b90f 100644 --- a/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java +++ b/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java @@ -55,7 +55,7 @@ import java.util.HashSet; import java.util.concurrent.ConcurrentHashMap; /** - * The HadoopAccessorService returns HadoopAccessor instances configured to work on behalf of a user-group. <p/> The + * The HadoopAccessorService returns HadoopAccessor instances configured to work on behalf of a user-group. <p> The * default accessor used is the base accessor which just injects the UGI into the configuration instance used to * create/obtain JobClient and FileSystem instances. */ @@ -285,7 +285,7 @@ public class HadoopAccessorService implements Service { /** * Creates a JobConf using the site configuration for the specified hostname:port. - * <p/> + * <p> * If the specified hostname:port is not defined it falls back to the '*' site * configuration if available. If the '*' site configuration is not available, * the JobConf has all Hadoop defaults. @@ -366,7 +366,7 @@ public class HadoopAccessorService implements Service { /** * Returns a Configuration containing any defaults for an action for a particular cluster. - * <p/> + * <p> * This configuration is used as default for the action configuration and enables cluster * level default values per action. * http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/InstrumentationService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/InstrumentationService.java b/core/src/main/java/org/apache/oozie/service/InstrumentationService.java index 0572f7f..3d887bb 100644 --- a/core/src/main/java/org/apache/oozie/service/InstrumentationService.java +++ b/core/src/main/java/org/apache/oozie/service/InstrumentationService.java @@ -26,8 +26,8 @@ import java.util.Map; /** - * This service provides an {@link Instrumentation} instance configured to support samplers. <p/> This service depends - * on the {@link SchedulerService}. <p/> The {@link #CONF_LOGGING_INTERVAL} configuration property indicates how often + * This service provides an {@link Instrumentation} instance configured to support samplers. <p> This service depends + * on the {@link SchedulerService}. <p> The {@link #CONF_LOGGING_INTERVAL} configuration property indicates how often * snapshots of the instrumentation should be logged. */ public class InstrumentationService implements Service { http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java b/core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java index a89258a..da2b9aa 100644 --- a/core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java +++ b/core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java @@ -121,7 +121,6 @@ public class JobsConcurrencyService implements Service, Instrumentable { * is the OOZIE_INSTANCE_ID env var and the value is the URL (of this Oozie server). * * @return A map of Oozie instance ids and URLs - * @throws Exception */ public Map<String, String> getServerUrls() { return urls; @@ -131,7 +130,6 @@ public class JobsConcurrencyService implements Service, Instrumentable { * Return a map of instance id to other Oozie servers URL in HA. This implementation always returns a empty map. * * @return A map of Oozie instance ids and URLs - * @throws Exception */ public Map<String, String> getOtherServerUrls() { return new HashMap<String, String>(); http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/LiteWorkflowAppService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/LiteWorkflowAppService.java b/core/src/main/java/org/apache/oozie/service/LiteWorkflowAppService.java index deeddc5..f27b283 100644 --- a/core/src/main/java/org/apache/oozie/service/LiteWorkflowAppService.java +++ b/core/src/main/java/org/apache/oozie/service/LiteWorkflowAppService.java @@ -33,7 +33,6 @@ public class LiteWorkflowAppService extends WorkflowAppService { * Parse workflow definition. * * @param jobConf workflow job configuration. - * @param authToken authorization token. * @return workflow application. */ public WorkflowApp parseDef(Configuration jobConf) throws WorkflowException { http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java b/core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java index f1f26ec..99ace13 100644 --- a/core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java +++ b/core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java @@ -70,7 +70,7 @@ public abstract class LiteWorkflowStoreService extends WorkflowStoreService { public static final String USER_ERROR_CODE_ALL = "ALL"; /** - * Delegation method used by the Action and Decision {@link NodeHandler} on start. <p/> This method provides the + * Delegation method used by the Action and Decision {@link NodeHandler} on start. <p> This method provides the * necessary information to create ActionExecutors. * * @param context NodeHandler context. @@ -209,7 +209,7 @@ public abstract class LiteWorkflowStoreService extends WorkflowStoreService { } /** - * Delegation method used when failing actions. <p/> + * Delegation method used when failing actions. <p> * * @param context NodeHandler context. */ @@ -219,7 +219,7 @@ public abstract class LiteWorkflowStoreService extends WorkflowStoreService { } /** - * Delegation method used when killing actions. <p/> + * Delegation method used when killing actions. <p> * * @param context NodeHandler context. */ @@ -229,7 +229,7 @@ public abstract class LiteWorkflowStoreService extends WorkflowStoreService { } /** - * Used to terminate jobs - FAIL or KILL. <p/> + * Used to terminate jobs - FAIL or KILL. <p> * * @param context NodeHandler context. * @param transientVar The transient variable name. http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java b/core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java index 29f6294..2a00a73 100644 --- a/core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java +++ b/core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java @@ -24,7 +24,7 @@ import org.apache.oozie.util.MetricsInstrumentation; /** * This service provides an {@link Instrumentation} instance mostly compatible with the original Instrumentation, but backed by - * Codahale Metrics. <p/> This service depends on the {@link SchedulerService}. <p/> The {@link #CONF_LOGGING_INTERVAL} + * Codahale Metrics. <p> This service depends on the {@link SchedulerService}. <p> The {@link #CONF_LOGGING_INTERVAL} * configuration property indicates how often snapshots of the instrumentation should be logged. */ public class MetricsInstrumentationService extends InstrumentationService { http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java b/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java index a350772..b59361b 100644 --- a/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java +++ b/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java @@ -193,7 +193,6 @@ public class PartitionDependencyManagerService implements Service { * @param db name of the database * @param table name of the table * @param partitions list of available partitions - * @return list of actionIDs for which the dependency is now available */ public void partitionAvailable(String server, String db, String table, Map<String, String> partitions) { Collection<String> actionsWithAvailableDep = dependencyCache.markDependencyAvailable(server, db, table, @@ -237,8 +236,6 @@ public class PartitionDependencyManagerService implements Service { * Remove a coord action from dependency cache when all push missing dependencies available * * @param actionID action id - * @param dependencyURIs set of dependency URIs - * @return true if successful, else false */ public void removeCoordActionWithDependenciesAvailable(String actionID) { if (purgeEnabled) { http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/ProxyUserService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/ProxyUserService.java b/core/src/main/java/org/apache/oozie/service/ProxyUserService.java index 65e377f..39b5774 100644 --- a/core/src/main/java/org/apache/oozie/service/ProxyUserService.java +++ b/core/src/main/java/org/apache/oozie/service/ProxyUserService.java @@ -35,15 +35,15 @@ import java.util.Set; /** * The ProxyUserService checks if a user of a request has proxyuser privileges. - * <p/> + * <p> * This check is based on the following criteria: - * <p/> + * <p> * <ul> * <li>The user of the request must be configured as proxy user in Oozie configuration.</li> * <li>The user of the request must be making the request from a whitelisted host.</li> * <li>The user of the request must be making the request on behalf of a user of a whitelisted group.</li> * </ul> - * <p/> + * <p> */ public class ProxyUserService implements Service { private static XLog LOG = XLog.getLog(ProxyUserService.class); http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/SLAStoreService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/SLAStoreService.java b/core/src/main/java/org/apache/oozie/service/SLAStoreService.java index 22f45f8..02899cc 100644 --- a/core/src/main/java/org/apache/oozie/service/SLAStoreService.java +++ b/core/src/main/java/org/apache/oozie/service/SLAStoreService.java @@ -38,7 +38,7 @@ public class SLAStoreService implements Service { } /** - * Return a SLA store instance with a fresh transaction. <p/> The LSA store has to be committed and then closed to + * Return a SLA store instance with a fresh transaction. <p> The LSA store has to be committed and then closed to * commit changes, if only close it rolls back. * * @return a SLA store. @@ -54,7 +54,7 @@ public class SLAStoreService implements Service { } /** - * Return a SLA store instance with an existing transaction. <p/> The SLA store has to be committed and then closed + * Return a SLA store instance with an existing transaction. <p> The SLA store has to be committed and then closed * to commit changes, if only close it rolls back. * * @return a SLA store. http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/SchedulerService.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/SchedulerService.java b/core/src/main/java/org/apache/oozie/service/SchedulerService.java index b63a004..dc9e76c 100644 --- a/core/src/main/java/org/apache/oozie/service/SchedulerService.java +++ b/core/src/main/java/org/apache/oozie/service/SchedulerService.java @@ -28,8 +28,8 @@ import java.util.concurrent.ScheduledThreadPoolExecutor; import java.util.concurrent.TimeUnit; /** - * This service executes scheduled Runnables and Callables at regular intervals. <p/> It uses a - * java.util.concurrent.ScheduledExecutorService. <p/> The {@link #SCHEDULER_THREADS} configuration property indicates + * This service executes scheduled Runnables and Callables at regular intervals. <p> It uses a + * java.util.concurrent.ScheduledExecutorService. <p> The {@link #SCHEDULER_THREADS} configuration property indicates * how many threads the scheduler will use to run scheduled commands. */ public class SchedulerService implements Service { @@ -84,7 +84,7 @@ public class SchedulerService implements Service { } /** - * Return the java.util.concurrent.ScheduledExecutorService instance used by the SchedulerService. <p/> + * Return the java.util.concurrent.ScheduledExecutorService instance used by the SchedulerService. <p> * * @return the scheduled executor service instance. */ http://git-wip-us.apache.org/repos/asf/oozie/blob/fcbab934/core/src/main/java/org/apache/oozie/service/Service.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/oozie/service/Service.java b/core/src/main/java/org/apache/oozie/service/Service.java index f3b1280..4e9c921 100644 --- a/core/src/main/java/org/apache/oozie/service/Service.java +++ b/core/src/main/java/org/apache/oozie/service/Service.java @@ -30,7 +30,7 @@ public interface Service { public static final String CONF_PREFIX = "oozie.service."; /** - * Initialize the service. <p/> Invoked by the {@link Service} singleton at start up time. + * Initialize the service. <p> Invoked by the {@link Service} singleton at start up time. * * @param services services singleton initializing the service. * @throws ServiceException thrown if the service could not initialize. @@ -38,12 +38,12 @@ public interface Service { public void init(Services services) throws ServiceException; /** - * Destroy the service. <p/> Invoked by the {@link Service} singleton at shutdown time. + * Destroy the service. <p> Invoked by the {@link Service} singleton at shutdown time. */ public void destroy(); /** - * Return the public interface of the service. <p/> Services are retrieved by its public interface. Specializations + * Return the public interface of the service. <p> Services are retrieved by its public interface. Specializations * of services must return the public interface. * * @return the interface of the service.
