Repository: oozie
Updated Branches:
  refs/heads/master 16992c1f5 -> 76d9b64f9


OOZIE-3229 [build] test-patch-30-distro improvement (asalamon74 via 
andras.piros)


Project: http://git-wip-us.apache.org/repos/asf/oozie/repo
Commit: http://git-wip-us.apache.org/repos/asf/oozie/commit/76d9b64f
Tree: http://git-wip-us.apache.org/repos/asf/oozie/tree/76d9b64f
Diff: http://git-wip-us.apache.org/repos/asf/oozie/diff/76d9b64f

Branch: refs/heads/master
Commit: 76d9b64f902754de8cdb3848c8eb4a2ce186da94
Parents: 16992c1
Author: Andras Piros <[email protected]>
Authored: Fri Aug 17 15:38:30 2018 +0200
Committer: Andras Piros <[email protected]>
Committed: Fri Aug 17 15:38:30 2018 +0200

----------------------------------------------------------------------
 bin/test-patch-30-distro | 20 ++++++++++----------
 release-log.txt          |  1 +
 2 files changed, 11 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/oozie/blob/76d9b64f/bin/test-patch-30-distro
----------------------------------------------------------------------
diff --git a/bin/test-patch-30-distro b/bin/test-patch-30-distro
index f72d516..ad7e1c5 100755
--- a/bin/test-patch-30-distro
+++ b/bin/test-patch-30-distro
@@ -16,7 +16,7 @@ if [ "${TESTPATCHDEBUG}" == "true" ] ; then
   set -x
 fi
 
-BASEDIR=$(pwd)
+#BASEDIR=$(pwd)
 TASKNAME="DISTRO"
 OP=""
 TEMPDIR=""
@@ -27,7 +27,7 @@ MVNPASSTHRU=""
 
 ###############################################################################
 cleanupAndExit() {
-  exit $1
+  exit "$1"
 }
 ###############################################################################
 printUsage() {
@@ -36,7 +36,7 @@ printUsage() {
 }
 ###############################################################################
 parseArgs() {
-  for i in $*
+  for i in "$@"
   do
     case $i in
     --taskname)
@@ -87,18 +87,18 @@ case $OP in
   pre)
     ;;
   post)
-    mvn package assembly:single -DgenerateDocs -DskipTests | tee 
${REPORTDIR}/${TASKNAME}.out >> $STDOUT
+    mvn clean package assembly:single -DgenerateDocs -DskipTests | tee 
"${REPORTDIR}/${TASKNAME}.out" >> $STDOUT
     exitCode=${PIPESTATUS[0]}
-    echo "$exitCode" >  ${TEMPDIR}/${TASKNAME}.exitCode
+    echo "$exitCode" >  "${TEMPDIR}/${TASKNAME}.exitCode"
     ;;
   report)
-    exitCode=`cat ${TEMPDIR}/${TASKNAME}.exitCode`
+    exitCode=$(cat "${TEMPDIR}/${TASKNAME}.exitCode")
     if [[ "$exitCode" != "0" ]] ; then
-      echo "{color:red}-1 ${TASKNAME}{color}" >> $SUMMARYFILE
-      echo ".    {color:red}-1{color} distro tarball fails with the patch" >> 
$SUMMARYFILE
+      echo "{color:red}-1 ${TASKNAME}{color}" >> "$SUMMARYFILE"
+      echo ".    {color:red}-1{color} distro tarball fails with the patch" >> 
"$SUMMARYFILE"
          else
-      echo "{color:green}+1 ${TASKNAME}{color}" >> $SUMMARYFILE
-      echo ".    {color:green}+1{color} distro tarball builds with the patch " 
>> $SUMMARYFILE
+      echo "{color:green}+1 ${TASKNAME}{color}" >> "$SUMMARYFILE"
+      echo ".    {color:green}+1{color} distro tarball builds with the patch " 
>> "$SUMMARYFILE"
     fi
     ;;
 esac

http://git-wip-us.apache.org/repos/asf/oozie/blob/76d9b64f/release-log.txt
----------------------------------------------------------------------
diff --git a/release-log.txt b/release-log.txt
index 39a821b..7d0363e 100644
--- a/release-log.txt
+++ b/release-log.txt
@@ -1,5 +1,6 @@
 -- Oozie 5.1.0 release (trunk - unreleased)
 
+OOZIE-3229 [build] test-patch-30-distro improvement (asalamon74 via 
andras.piros)
 OOZIE-3324 Cannot compile with findbugs check (asalamon74 via pbacsko)
 OOZIE-3304 Parsing sharelib timestamps is not threadsafe (dionusos, matijhs 
via andras.piros)
 OOZIE-3314 Remove findbugs-filter.xml and convert its contents to annotations 
(asalamon74 via andras.piros)

Reply via email to