suyanhanx commented on code in PR #1797:
URL:
https://github.com/apache/incubator-opendal/pull/1797#discussion_r1151852244
##########
bindings/nodejs/index.d.ts:
##########
@@ -130,4 +130,11 @@ export class PresignedRequest {
* The key of the map is the header name, and the value is the header value.
*/
headers(): Record<string, string>
+ /**
+ * Returns the JSON serialization result of this request.
+ *
+ * As the PresignedRequest cannot be serialized directly in JavaScript side.
+ * This is useful to pass to client or third party to create a request
directly.
+ */
+ toJSON(): string
Review Comment:
> I think is good to have
You are right. It's just `good to have`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
