suyanhanx commented on code in PR #1813:
URL:
https://github.com/apache/incubator-opendal/pull/1813#discussion_r1153981224
##########
bindings/nodejs/package.json:
##########
@@ -59,15 +59,12 @@
"node": ">= 10"
},
"scripts": {
- "artifacts": "napi artifacts",
- "build": "napi build --platform --release --js generated.js && node
./scripts/header.js",
- "build:debug": "napi build --platform --js generated.js && node
./scripts/header.js",
+ "build": "napi build --platform --target \"${NAPI_TARGET:-}\" --release
--js generated.js && node ./scripts/header.js",
+ "build:debug": "napi build --platform --target \"${NAPI_TARGET:-}\" --js
generated.js && node ./scripts/header.js",
"docs": "typedoc",
"format": "prettier --write .",
- "prepublishOnly": "napi prepublish -t npm",
Review Comment:
No. It is part of the publish lifecycle.It will be automatically executed in
publish.
https://docs.npmjs.com/cli/v9/using-npm/scripts#prepare-and-prepublish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
