Ji-Xinyou commented on PR #1861:
URL: 
https://github.com/apache/incubator-opendal/pull/1861#issuecomment-1499200124

   I have added the `Result` and `Error` types for error handling. Error 
handling with strings is tricky in C, so the code is a litlle bit complex, 
making this a relatively big PR. Thanks everyone in advance for spending time 
reviewing this.
   
   Some explainations:
   
   * I did not use generics on Result type even cbindgen supports it because 
the naming of generics in cbindgen is unacceptable.
   * I allocates the error on heap since it contains error message.
   * I use Rust-like Result type in C since I found it very elegant for error 
handling.
   
   I would really appreciate any review and suggestions on the PR and feel free 
to contact me for any changes or questions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to