Ji-Xinyou commented on code in PR #1892:
URL: 
https://github.com/apache/incubator-opendal/pull/1892#discussion_r1161852656


##########
bindings/c/include/opendal.h:
##########
@@ -147,6 +148,16 @@ typedef struct opendal_result_read {
   enum opendal_code code;
 } opendal_result_read;
 
+/*
+ The result type for [`opendal_operator_is_exist()`], the field `exist`
+ contains whether the path exists, and the field `code` contains the
+ corresponding error code.
+ */
+typedef struct opendal_result_exist {

Review Comment:
   > By the way, is it a good idea for use diffent naming style for struct and 
function? For example:
   > 
   > * `struct`: `OpendalOperator`, `OpendalResultOperatorIsExist`
   > * `function`: `opendal_operator_is_exist`
   
   I think this is a good idea in most cases.
   But AFAIK, in C, most libraries and programs use `snake_case` for structs, 
functions and variables, and in C++, they use CamelCase.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to