kidylee commented on code in PR #1894:
URL: 
https://github.com/apache/incubator-opendal/pull/1894#discussion_r1162245757


##########
bindings/java/src/lib.rs:
##########
@@ -188,3 +234,27 @@ fn build_operator(
 
     Ok(op)
 }
+
+fn convert_map(env: &mut JNIEnv, params: &JObject) -> HashMap<String, String> {

Review Comment:
   OK, I'm remove `build_operator` as well, since this method is redundant 
cross bindings, we could do it properly with a sharing lib or a macro.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to