v0y4g3r commented on issue #1607: URL: https://github.com/apache/incubator-opendal/issues/1607#issuecomment-1502661985
After investigated the code of writers, it turns out that `Writer::append` has to kinds of implementations, one is based on multipart upload (mostly object storage backends like S3) and the other is based on posix-like APIs, like `FsWriter`, `FtpWriter` and `HdfsWriter`. While in the later, some writer has "atomic write" features (`FsWriter`). So: - For S3-like backends, `Writer::abort` is meaningful in that partially uploaded objects will also be charged for storage. - For posix-like backends with atomic write enabled, `Writer::abort` is meaningful in that partial files are stored in a temp directory and cleaning that directory on abortion is necessary. - For posix-like backends without atomic write feature,`Writer::append` directly appends bytes to orignal files. I wonder if it's ok to delete partial files on abortion? Please let me know if you guys have any idea on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
