suyanhanx commented on code in PR #1908:
URL:
https://github.com/apache/incubator-opendal/pull/1908#discussion_r1162671713
##########
core/src/services/gcs/backend.rs:
##########
@@ -194,19 +195,9 @@ impl GcsBuilder {
self
}
- /// Specify the signer directly instead of building by OpenDAL.
- ///
- /// If signer is specified, the following settings will not be used
- /// any more:
- ///
- /// - `scope`
- /// - `service_account`
- /// - `credential`
- /// - `credential_path`
- ///
- /// PLEASE USE THIS API CAREFULLY.
- pub fn signer(&mut self, signer: GoogleSigner) -> &mut Self {
- self.signer = Some(Arc::new(signer));
+ /// Specify the customed token load used by this service.
Review Comment:
```suggestion
/// Specify the customed token loader used by this service.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]