PsiACE commented on code in PR #1931:
URL:
https://github.com/apache/incubator-opendal/pull/1931#discussion_r1164943437
##########
core/src/layers/minitrace.rs:
##########
@@ -150,19 +150,33 @@ impl<A: Accessor> LayeredAccessor for
MinitraceAccessor<A> {
}
async fn read(&self, path: &str, args: OpRead) -> Result<(RpRead,
Self::Reader)> {
- let span = Span::enter_with_local_parent("read");
self.inner
.read(path, args)
- .map(|v| v.map(|(rp, r)| (rp, MinitraceWrapper::new(span, r))))
+ .map(|v| {
+ v.map(|(rp, r)| {
+ (
+ rp,
+
MinitraceWrapper::new(Span::enter_with_local_parent("ReadOperation"), r),
Review Comment:
for inner op , we can use the operation wich provids display
```
impl<R: oio::BlockingPage> oio::BlockingPage for MinitraceWrapper<R> {
fn next(&mut self) -> Result<Option<Vec<oio::Entry>>> {
let _span =
Span::enter_with_parent(PageOperation::BlockingNext.into_static(), &self.span);
self.inner.next()
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
