Xuanwo commented on code in PR #1937:
URL:
https://github.com/apache/incubator-opendal/pull/1937#discussion_r1166387201
##########
core/src/services/fs/writer.rs:
##########
@@ -75,6 +75,14 @@ impl oio::Write for FsWriter<tokio::fs::File> {
Ok(())
}
+ async fn abort(&mut self) -> Result<()> {
+ // TODO(hl)
Review Comment:
ditto.
##########
core/src/services/oss/writer.rs:
##########
@@ -114,6 +114,14 @@ impl oio::Write for OssWriter {
}
}
+ async fn abort(&mut self) -> Result<()> {
+ // TODO(hl)
Review Comment:
Please remove this comment.
##########
core/src/raw/oio/write.rs:
##########
@@ -65,6 +67,7 @@ impl From<WriteOperation> for &'static str {
BlockingWrite => "BlockingWriter::write",
BlockingAppend => "BlockingWriter::append",
BlockingClose => "BlockingWriter::close",
+ Abort => "Writer::abort",
Review Comment:
Please arrange `Abort` under `Append`.
##########
core/src/raw/adapters/kv/backend.rs:
##########
@@ -293,6 +293,14 @@ impl<S: Adapter> oio::Write for KvWriter<S> {
Ok(())
}
+ async fn abort(&mut self) -> Result<()> {
+ // TODO(hl)
Review Comment:
ditto.
##########
core/src/services/hdfs/writer.rs:
##########
@@ -70,6 +70,14 @@ impl oio::Write for HdfsWriter<hdrs::AsyncFile> {
Ok(())
}
+ async fn abort(&mut self) -> Result<()> {
+ // TODO(hl)
Review Comment:
Please remove this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
