Xuanwo commented on code in PR #1996:
URL:
https://github.com/apache/incubator-opendal/pull/1996#discussion_r1166686083
##########
core/src/services/gcs/core.rs:
##########
@@ -149,19 +155,32 @@ impl GcsCore {
write!(&mut url, "&predefinedAcl={}", acl).unwrap();
}
- let mut req = Request::post(&url);
+ let mut req =
+ Request::post(&url).header(CONTENT_TYPE, "multipart/related;
boundary=my-boundary");
Review Comment:
I don't feel comfortable with handwriting multipart request. How about using
`reqwest` multipart support? We can extend `AsyncBody`'s Multipart to allow
multiple fields.
Example could be found at
https://github.com/apache/incubator-opendal/blob/main/core/src/services/ipmfs/writer.rs#L44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
