thorseraq commented on code in PR #1997:
URL:
https://github.com/apache/incubator-opendal/pull/1997#discussion_r1166751424
##########
core/src/services/oss/core.rs:
##########
@@ -162,6 +163,10 @@ impl OssCore {
req = req.header("x-oss-range-behavior", "standard");
}
+ if let Some(if_none_match) = if_none_match {
+ req = req.header(http::header::IF_NONE_MATCH, if_none_match);
Review Comment:
Sure! I made some change at
https://github.com/apache/incubator-opendal/pull/1997/commits/0f67380897c5230efe8e9cfb1229faa36408fca0,
is it the preferred style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
