cuichenli commented on PR #1801:
URL:
https://github.com/apache/incubator-opendal/pull/1801#issuecomment-1509882067
> I apologize for closing this pull request. Our policy has been updated,
and we will no longer close pull requests so hastily. Additionally, I have
recently learned that once a maintainer closes a pull request, it cannot be
reopened.
No problem at all! I apologize for the delay in updating the PR as I have
been busy with other tasks.
I have made some changes to use the streaming API in the latest commit.
However, I must admit that the implementation is not optimal. The main issue
arises during the final chunk, where we need to specify the final chunk size.
Since this size is unknown until the user invokes the close function, the
implementation became a bit tricky. I attempted to send a POST request with an
empty body, but unfortunately, it did not work. As an alternative, I recorded
the last copy sent and when the user invokes the close function, I resend it
with the correct headers. I am uncertain whether this approach is acceptable,
but I cannot think of a better solution at this time.
Please take a look. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
