suyanhanx commented on code in PR #2007: URL: https://github.com/apache/incubator-opendal/pull/2007#discussion_r1167755812
########## website/docs/index.md: ########## Review Comment: Wouldn't it be a little bit not enough? ########## website/docs/vision.md: ########## @@ -0,0 +1,54 @@ +--- +title: Vision +sidebar_position: 2 +--- + +OpenDAL VISION: **access data freely**. + +### Free from services + +OpenDAL must enable users to access various storage services ranging from `s3` to `dropbox` via it's own native API. It should provide a unified API for accessing all these services. + +- Add support for google drive: Good, it allows users to access and manage their data on the google drive. +- Add support for oss via native API: Good, users can utilize Aliyun's RAM support. +- Add support for [supabase storage](https://supabase.com/docs/guides/storage): Good, users can visit supabase storage now! + + +- Add support for gcs via XML API: Bad, gcs has native JSON API which more powerful +- Add support for MySQL/PostgreSQL: Bad, relational DBMS provides data types such as BLOB, but they are often not used as a storage service. + +### Free from implementations + +OpenDAL needs to separate the various implementation details of services and enables users to write identical logic for different services. + +- Add a new capability to indicate whether or not `presign` is supported: Good, users can now write logic based on the `can_presign` option. +- Add a `default_storage_class` configuration for the S3 service: Good, configuration is specific to the s3 service. +- Add an option for `content_type` in the `write` operation: Good, it aligns with HTTP standards. + + +- Add a new option in read for `storage_class`: Bad, as different services could have varying values for this parameter. + +### Free to integrate + +OpenDAL needs to be integrated with different systems. + +- Add python binding: Good, users from `python` can use OpenDAL. +- Add object_store integration: Good, users of `object_store` can adopt OpenDAL. + + +- Rewrite OpenDAL in Golang: Good idea itself, but not related to OpenDAL. Review Comment: What does this part mean? This doesn't look like some kind of vision. ########## website/docs/vision.md: ########## @@ -0,0 +1,54 @@ +--- +title: Vision +sidebar_position: 2 +--- + +OpenDAL VISION: **access data freely**. + +### Free from services + +OpenDAL must enable users to access various storage services ranging from `s3` to `dropbox` via it's own native API. It should provide a unified API for accessing all these services. + +- Add support for google drive: Good, it allows users to access and manage their data on the google drive. +- Add support for oss via native API: Good, users can utilize Aliyun's RAM support. +- Add support for [supabase storage](https://supabase.com/docs/guides/storage): Good, users can visit supabase storage now! + + +- Add support for gcs via XML API: Bad, gcs has native JSON API which more powerful +- Add support for MySQL/PostgreSQL: Bad, relational DBMS provides data types such as BLOB, but they are often not used as a storage service. Review Comment: Need to handle case correctly. (plus maybe follow with the full name?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
