v0y4g3r commented on code in PR #2018:
URL: 
https://github.com/apache/incubator-opendal/pull/2018#discussion_r1168437057


##########
core/tests/behavior/write.rs:
##########
@@ -578,6 +579,25 @@ pub async fn test_read_with_special_chars(op: Operator) -> 
Result<()> {
     Ok(())
 }
 
+// Delete existing file should succeed.
+pub async fn test_abort_writer(op: Operator) -> Result<()> {
+    let path = uuid::Uuid::new_v4().to_string();
+    let (content, _) = gen_bytes();
+
+    let mut writer = op.writer(&path).await.unwrap();
+    if let Err(e) = writer.append(content).await {
+        assert_eq!(e.kind(), ErrorKind::Unsupported);

Review Comment:
   > We should skip the entire test if `append` or `abort` not supported.
   
   True, I forgot this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to