SkyFan2002 commented on code in PR #2006:
URL: 
https://github.com/apache/incubator-opendal/pull/2006#discussion_r1168867437


##########
core/src/layers/mod.rs:
##########
@@ -18,37 +18,53 @@
 //! `Layer` is the mechanism to intercept operations.
 
 mod concurrent_limit;
+
 pub use concurrent_limit::ConcurrentLimitLayer;
 
 mod immutable_index;
+
 pub use immutable_index::ImmutableIndexLayer;
 
 mod logging;
+
 pub use logging::LoggingLayer;
 
 #[cfg(feature = "layers-chaos")]
 mod chaos;
+
 #[cfg(feature = "layers-chaos")]
 pub use chaos::ChaosLayer;
 
 #[cfg(feature = "layers-metrics")]
 mod metrics;
+
 #[cfg(feature = "layers-metrics")]
 pub use self::metrics::MetricsLayer;
 
 mod retry;
+
 pub use self::retry::RetryLayer;
 
 #[cfg(feature = "layers-tracing")]
 mod tracing;
+
 #[cfg(feature = "layers-tracing")]
 pub use self::tracing::TracingLayer;
 
 mod type_eraser;
+
 pub(crate) use type_eraser::TypeEraseLayer;
 
 mod error_context;
+
 pub(crate) use error_context::ErrorContextLayer;
 
 mod complete;
+
 pub(crate) use complete::CompleteLayer;
+
+mod simulation;
+
+pub use simulation::MadsimLayer;
+#[cfg(madsim)]

Review Comment:
   I'm sorry that `cfg` cannot be removed totally, as some core mods of madsim 
can only be compiled with ` RUSTFLAGS="--cfg madsim"', but I have changed 
madsim layer into a feature. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to