suyanhanx commented on code in PR #2035:
URL:
https://github.com/apache/incubator-opendal/pull/2035#discussion_r1170837034
##########
core/src/services/azblob/core.rs:
##########
@@ -126,6 +128,10 @@ impl AzblobCore {
req = req.header(http::header::RANGE, range.to_header());
}
+ if let Some(etag) = if_none_match {
Review Comment:
Would you like to keep the variable name consistent? I was a little confused
at first galance.
##########
core/src/services/azblob/core.rs:
##########
@@ -182,7 +189,11 @@ impl AzblobCore {
percent_encode_path(&p)
);
- let req = Request::head(&url);
+ let mut req = Request::head(&url);
+
+ if let Some(etag) = if_none_match {
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
