Xuanwo commented on code in PR #2074: URL: https://github.com/apache/incubator-opendal/pull/2074#discussion_r1174507673
########## core/src/docs/upgrade.md: ########## @@ -1,3 +1,18 @@ +# Upgrade to v0.33 + +OpenDAL 0.33 redesigned the `Writer` API. + +- All `writer.append()` should be replaced by `writer.write()` instead. + +Please refer to [`Writer`](crate::Writer) for more details. + +And internally, services should handle `OpWrite::content_length` correctly. + +- If writer doesn't support upload unsized data, please return `NotSupported` if `content_length` is `None`. Review Comment: > Maybe need to write more from the user's perspective? Nice catch. OpenDAL has two kinds of users: public API user and raw API user. Let me polis this part a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
