Xuanwo commented on code in PR #2096:
URL: 
https://github.com/apache/incubator-opendal/pull/2096#discussion_r1174773626


##########
core/src/services/s3/core.rs:
##########
@@ -468,6 +469,11 @@ impl S3Core {
         if let Some(limit) = limit {
             write!(url, "&max-keys={limit}").expect("write into string must 
succeed");
         }
+        if let Some(start_after) = start_after {
+            let start_after = format!("{}{}", &p, &start_after);

Review Comment:
   Please use `build_abs_path` to build it. `start_after` should be relative to 
`root` instead of `path`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to