This is an automated email from the ASF dual-hosted git repository.

xuanwo pushed a commit to branch refactor-tests
in repository https://gitbox.apache.org/repos/asf/incubator-opendal.git

commit 1451feff59c77435119e28531fcabbcb3c167a9d
Author: Xuanwo <[email protected]>
AuthorDate: Wed May 3 01:37:17 2023 +0800

    refactor: Move not initiated logic to utils instead
    
    Signed-off-by: Xuanwo <[email protected]>
---
 core/tests/behavior/blocking_copy.rs   | 1 -
 core/tests/behavior/blocking_list.rs   | 1 -
 core/tests/behavior/blocking_read.rs   | 1 -
 core/tests/behavior/blocking_rename.rs | 1 -
 core/tests/behavior/blocking_write.rs  | 1 -
 core/tests/behavior/copy.rs            | 1 -
 core/tests/behavior/list.rs            | 1 -
 core/tests/behavior/list_only.rs       | 1 -
 core/tests/behavior/main.rs            | 4 +++-
 core/tests/behavior/presign.rs         | 1 -
 core/tests/behavior/read_only.rs       | 1 -
 core/tests/behavior/rename.rs          | 1 -
 core/tests/behavior/utils.rs           | 2 ++
 core/tests/behavior/write.rs           | 1 -
 14 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/core/tests/behavior/blocking_copy.rs 
b/core/tests/behavior/blocking_copy.rs
index 346b8b45..e759492c 100644
--- a/core/tests/behavior/blocking_copy.rs
+++ b/core/tests/behavior/blocking_copy.rs
@@ -46,7 +46,6 @@ macro_rules! behavior_blocking_copy_test {
                             Ok(())
                         },
                         None => {
-                            log::warn!("service {} not initiated, ignored", 
opendal::Scheme::$service);
                             Ok(())
                         }
                     }
diff --git a/core/tests/behavior/blocking_list.rs 
b/core/tests/behavior/blocking_list.rs
index 20f333e5..94e9d80d 100644
--- a/core/tests/behavior/blocking_list.rs
+++ b/core/tests/behavior/blocking_list.rs
@@ -49,7 +49,6 @@ macro_rules! behavior_blocking_list_test {
                             Ok(())
                         },
                         None => {
-                            log::warn!("service {} not initiated, ignored", 
opendal::Scheme::$service);
                             Ok(())
                         }
                     }
diff --git a/core/tests/behavior/blocking_read.rs 
b/core/tests/behavior/blocking_read.rs
index 2033398c..44e4f590 100644
--- a/core/tests/behavior/blocking_read.rs
+++ b/core/tests/behavior/blocking_read.rs
@@ -45,7 +45,6 @@ macro_rules! behavior_blocking_read_test {
                             Ok(())
                         },
                         None => {
-                            log::warn!("service {} not initiated, ignored", 
opendal::Scheme::$service);
                             Ok(())
                         }
                     }
diff --git a/core/tests/behavior/blocking_rename.rs 
b/core/tests/behavior/blocking_rename.rs
index 3973a954..57f1986b 100644
--- a/core/tests/behavior/blocking_rename.rs
+++ b/core/tests/behavior/blocking_rename.rs
@@ -46,7 +46,6 @@ macro_rules! behavior_blocking_rename_test {
                             Ok(())
                         },
                         None => {
-                            log::warn!("service {} not initiated, ignored", 
opendal::Scheme::$service);
                             Ok(())
                         }
                     }
diff --git a/core/tests/behavior/blocking_write.rs 
b/core/tests/behavior/blocking_write.rs
index d1bd392b..5cae5c64 100644
--- a/core/tests/behavior/blocking_write.rs
+++ b/core/tests/behavior/blocking_write.rs
@@ -51,7 +51,6 @@ macro_rules! behavior_blocking_write_test {
                             Ok(())
                         },
                         None => {
-                            log::warn!("service {} not initiated, ignored", 
opendal::Scheme::$service);
                             Ok(())
                         }
                     }
diff --git a/core/tests/behavior/copy.rs b/core/tests/behavior/copy.rs
index dfe0a7cc..b01e8bf6 100644
--- a/core/tests/behavior/copy.rs
+++ b/core/tests/behavior/copy.rs
@@ -44,7 +44,6 @@ macro_rules! behavior_copy_test {
                             Ok(())
                         },
                         None => {
-                            log::warn!("service {} not initiated, ignored", 
opendal::Scheme::$service);
                             Ok(())
                         }
                     }
diff --git a/core/tests/behavior/list.rs b/core/tests/behavior/list.rs
index 3324412e..41a4d2c5 100644
--- a/core/tests/behavior/list.rs
+++ b/core/tests/behavior/list.rs
@@ -54,7 +54,6 @@ macro_rules! behavior_list_test {
                             Ok(())
                         },
                         None => {
-                            log::warn!("service {} not initiated, ignored", 
opendal::Scheme::$service);
                             Ok(())
                         }
                     }
diff --git a/core/tests/behavior/list_only.rs b/core/tests/behavior/list_only.rs
index a7e86a45..4da313b4 100644
--- a/core/tests/behavior/list_only.rs
+++ b/core/tests/behavior/list_only.rs
@@ -42,7 +42,6 @@ macro_rules! behavior_list_only_test {
                             Ok(())
                         },
                         None => {
-                            log::warn!("service {} not initiated, ignored", 
opendal::Scheme::$service);
                             Ok(())
                         }
                     }
diff --git a/core/tests/behavior/main.rs b/core/tests/behavior/main.rs
index 3bae994c..7c6f2d8d 100644
--- a/core/tests/behavior/main.rs
+++ b/core/tests/behavior/main.rs
@@ -48,7 +48,7 @@ macro_rules! behavior_tests {
     ($($service:ident),*) => {
         paste::item! {
             $(
-                mod [<services_ $service:lower>] {
+                mod [<services_ $service:snake>] {
                     use once_cell::sync::Lazy;
 
                     static RUNTIME: Lazy<tokio::runtime::Runtime> = 
Lazy::new(|| {
@@ -133,6 +133,8 @@ behavior_tests!(S3);
 behavior_tests!(Sftp);
 #[cfg(feature = "services-sled")]
 behavior_tests!(Sled);
+#[cfg(feature = "services-vercel-artifacts")]
+behavior_tests!(VercelArtifacts);
 #[cfg(feature = "services-webdav")]
 behavior_tests!(Webdav);
 #[cfg(feature = "services-webhdfs")]
diff --git a/core/tests/behavior/presign.rs b/core/tests/behavior/presign.rs
index ae4ae039..90850866 100644
--- a/core/tests/behavior/presign.rs
+++ b/core/tests/behavior/presign.rs
@@ -50,7 +50,6 @@ macro_rules! behavior_presign_test {
                             Ok(())
                         },
                         None => {
-                            log::warn!("service {} not initiated, ignored", 
opendal::Scheme::$service);
                             Ok(())
                         }
                     }
diff --git a/core/tests/behavior/read_only.rs b/core/tests/behavior/read_only.rs
index 5fe41660..9c1f60c6 100644
--- a/core/tests/behavior/read_only.rs
+++ b/core/tests/behavior/read_only.rs
@@ -45,7 +45,6 @@ macro_rules! behavior_read_test {
                             Ok(())
                         },
                         None => {
-                            log::warn!("service {} not initiated, ignored", 
opendal::Scheme::$service);
                             Ok(())
                         }
                     }
diff --git a/core/tests/behavior/rename.rs b/core/tests/behavior/rename.rs
index cf4c0173..1507e3dc 100644
--- a/core/tests/behavior/rename.rs
+++ b/core/tests/behavior/rename.rs
@@ -44,7 +44,6 @@ macro_rules! behavior_rename_test {
                             Ok(())
                         },
                         None => {
-                            log::warn!("service {} not initiated, ignored", 
opendal::Scheme::$service);
                             Ok(())
                         }
                     }
diff --git a/core/tests/behavior/utils.rs b/core/tests/behavior/utils.rs
index fdf877d6..3661f5f2 100644
--- a/core/tests/behavior/utils.rs
+++ b/core/tests/behavior/utils.rs
@@ -25,6 +25,7 @@ use std::usize;
 
 use bytes::Bytes;
 use log::debug;
+use log::warn;
 use opendal::layers::LoggingLayer;
 use opendal::layers::RetryLayer;
 use opendal::*;
@@ -54,6 +55,7 @@ pub fn init_service<B: Builder>() -> Option<Operator> {
     let turn_on_test = cfg.get("test").cloned().unwrap_or_default();
 
     if turn_on_test != "on" && turn_on_test != "true" {
+        warn!("service {} not initiated, ignored", B::SCHEME);
         return None;
     }
 
diff --git a/core/tests/behavior/write.rs b/core/tests/behavior/write.rs
index 38f9a3f9..9b7b4b04 100644
--- a/core/tests/behavior/write.rs
+++ b/core/tests/behavior/write.rs
@@ -57,7 +57,6 @@ macro_rules! behavior_write_test {
                             Ok(())
                         },
                         None => {
-                            log::warn!("service {} not initiated, ignored", 
opendal::Scheme::$service);
                             Ok(())
                         }
                     }

Reply via email to