ShadowySpirits commented on code in PR #2209:
URL:
https://github.com/apache/incubator-opendal/pull/2209#discussion_r1185738014
##########
bindings/java/src/test/java/org/apache/opendal/AsyncStepsTest.java:
##########
@@ -40,7 +40,7 @@ public void a_new_open_dal_async_operator() {
@When("Async write path {string} with content {string}")
public void async_write_path_test_with_content_hello_world(String
fileName, String content) {
Review Comment:
From my quick look, Cucumber's built-in type does not support byte array.
Reference: https://github.com/cucumber/cucumber-expressions#parameter-types
##########
bindings/java/src/util.rs:
##########
@@ -0,0 +1,128 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use std::collections::HashMap;
+
+use jni::objects::{JMap, JObject, JString, JThrowable, JValue};
+use jni::JNIEnv;
+use tokio::runtime::Runtime;
+
+use crate::{JENV, RUNTIME};
+
+pub(crate) unsafe fn get_runtime() -> &'static Runtime {
+ RUNTIME.get().unwrap()
+}
+
+pub(crate) unsafe fn jobject_into_map(
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
