wcy-fdu commented on code in PR #2143:
URL:
https://github.com/apache/incubator-opendal/pull/2143#discussion_r1185789571
##########
core/src/services/oss/backend.rs:
##########
@@ -123,6 +123,7 @@ pub struct OssBuilder {
access_key_secret: Option<String>,
http_client: Option<HttpClient>,
+ write_buffer_size: Option<usize>,
Review Comment:
I just noticed that the oss multipart size should be 100 KB to 5 GB, and
maybe we should also limit upper bound, although this upper bound is large, it
is rarely exceeded.
So I just keep naming it `writer_buffer_size` and do the size checking.
##########
core/src/services/s3/backend.rs:
##########
@@ -304,6 +304,8 @@ pub struct S3Builder {
http_client: Option<HttpClient>,
customed_credential_load: Option<Box<dyn AwsCredentialLoad>>,
+
+ write_buffer_size: Option<usize>,
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
