Xuanwo commented on code in PR #2247:
URL:
https://github.com/apache/incubator-opendal/pull/2247#discussion_r1188924633
##########
core/src/services/s3/backend.rs:
##########
@@ -373,8 +373,7 @@ impl S3Builder {
/// Region represent the signing region of this endpoint.
///
- /// - If region is set, we will take user's input first.
- /// - If not, we will use `us-east-1` as default.
+ /// This is a required parameter.
Review Comment:
Only required for AWS S3. Other services like minio will still fallback to
`us-east-1` as more of them assumed.
##########
core/src/services/s3/backend.rs:
##########
@@ -373,8 +373,7 @@ impl S3Builder {
/// Region represent the signing region of this endpoint.
///
- /// - If region is set, we will take user's input first.
- /// - If not, we will use `us-east-1` as default.
+ /// This is a required parameter.
Review Comment:
Only required for AWS S3. Other services like `minio` will still fallback to
`us-east-1` as more of them assumed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
