cuichenli commented on PR #2253:
URL: 
https://github.com/apache/incubator-opendal/pull/2253#issuecomment-1543386897

   some side notes: 
   
   noticed there are a lot of code duplicates, for instance: 
`obs_get_head_object_request` and `obs_get_head_object` share the same logic on 
setup the `req` object, not sure if it would be worth to extract the shared 
logic? 
   
   also for the `sign_query` method, not sure if it would be worth to make it 
as a trait? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to