Xuanwo commented on PR #2253: URL: https://github.com/apache/incubator-opendal/pull/2253#issuecomment-1543416890
> not sure if it would be worth to extract the shared logic? We can call `xxx_request` in `xxx`. > also for the `sign_query` method, not sure if it would be worth to make it as a trait? Make it a trait is not helpful because one service one has one valid `sign_query` implementaion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
