silver-ymz commented on PR #2263: URL: https://github.com/apache/incubator-opendal/pull/2263#issuecomment-1547674763
After some research, I think we may need to give up the sftp copy feature. There are 3 reasons: 1. Sftp `copy-file` extension is supported by few SFTP servers only. For example by [ProFTPD mod_sftp](http://www.proftpd.org/docs/contrib/mod_sftp.html) and Bitvise WinSSHD. The most widespread SFTP server, the OpenSSH supports related `copy-data` only in very recent [version 9.0](https://www.openssh.com/txt/release-9.0). 2. There are many ways to copy files except for `sftp`, such as direct `cp` in `ssh`, `scp`. There are very few users who use `sftp` to copy files. 3. Detecting the capability in `build` function costs expensively. We need to spawn a new process to initiate a complete connection, and find a file which has read-write permission to test copying. Moreover, all of these things will use `block_on` function, which makes the interaction with `tokio` becomes more complex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
