Xuanwo commented on code in PR #2260:
URL:
https://github.com/apache/incubator-opendal/pull/2260#discussion_r1195146674
##########
core/src/layers/complete.rs:
##########
@@ -646,3 +654,49 @@ where
Ok(())
}
}
+
+pub struct CompleteAppender<A> {
+ inner: Option<A>,
+}
+
+impl<A> CompleteAppender<A> {
+ pub fn new(inner: A) -> CompleteAppender<A> {
+ CompleteAppender { inner: Some(inner) }
+ }
+}
+
+/// Check if the appender has been closed while debug_assertions enabled.
+/// This code will never be executed in release mode.
+#[cfg(debug_assertions)]
+impl<A> Drop for CompleteAppender<A> {
+ fn drop(&mut self) {
+ if self.inner.is_none() {
+ // Do we need to panic here?
+ log::warn!("appender has not been closed, must be a bug")
+ }
+ }
+}
+
+#[async_trait]
+impl<A> oio::Append for CompleteAppender<A>
+where
+ A: oio::Append,
+{
+ async fn append(&mut self, bs: Bytes) -> Result<()> {
+ let a = self.inner.as_mut().ok_or_else(|| {
+ Error::new(ErrorKind::Unexpected, "appender has been closed or
aborted")
Review Comment:
appender doesn't have `abort`.
##########
core/src/layers/complete.rs:
##########
@@ -646,3 +654,49 @@ where
Ok(())
}
}
+
+pub struct CompleteAppender<A> {
+ inner: Option<A>,
+}
+
+impl<A> CompleteAppender<A> {
+ pub fn new(inner: A) -> CompleteAppender<A> {
+ CompleteAppender { inner: Some(inner) }
+ }
+}
+
+/// Check if the appender has been closed while debug_assertions enabled.
+/// This code will never be executed in release mode.
+#[cfg(debug_assertions)]
+impl<A> Drop for CompleteAppender<A> {
+ fn drop(&mut self) {
+ if self.inner.is_none() {
+ // Do we need to panic here?
Review Comment:
No, panic will break our test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
