Xuanwo commented on code in PR #2263:
URL:
https://github.com/apache/incubator-opendal/pull/2263#discussion_r1195153617
##########
core/src/services/sftp/backend.rs:
##########
@@ -55,8 +55,8 @@ use crate::*;
/// - [x] write
/// - [x] create_dir
/// - [x] delete
-/// - [ ] copy
-/// - [ ] rename
+/// - [ ] copy (partially, only supoort when remote server has copy-file
extension)
+/// - [x] rename (partially, only support to rename files on the same mount
point)
Review Comment:
The same.
##########
core/src/services/sftp/backend.rs:
##########
@@ -375,6 +373,40 @@ impl Accessor for SftpBackend {
Ok((RpWrite::new(), SftpWriter::new(file)))
}
+ async fn copy(&self, from: &str, to: &str, _args: OpCopy) ->
Result<RpCopy> {
Review Comment:
Please use `_` instead of `_args` if we don't want to use it.
##########
core/src/services/sftp/backend.rs:
##########
@@ -55,8 +55,8 @@ use crate::*;
/// - [x] write
/// - [x] create_dir
/// - [x] delete
-/// - [ ] copy
-/// - [ ] rename
+/// - [ ] copy (partially, only supoort when remote server has copy-file
extension)
Review Comment:
We don't need explain this: OpenDAL already implement all features, it's
server's own duty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
