Xuanwo commented on code in PR #2265:
URL:
https://github.com/apache/incubator-opendal/pull/2265#discussion_r1195888413
##########
core/src/services/fs/backend.rs:
##########
@@ -292,12 +292,12 @@ impl FsBackend {
#[async_trait]
impl Accessor for FsBackend {
- type Reader = oio::into_reader::FdReader<Compat<tokio::fs::File>>;
+ type Reader = oio::into_reader::FdReader<Compat<fs::File>>;
Review Comment:
I perfer to use `tokio::fs::File` here. We can remove the `use tokio::fs`
instead.
##########
core/src/services/fs/backend.rs:
##########
@@ -503,7 +503,7 @@ impl Accessor for FsBackend {
Ok(RpDelete::default())
}
- Err(err) if err.kind() == std::io::ErrorKind::NotFound =>
Ok(RpDelete::default()),
+ Err(err) if err.kind() == io::ErrorKind::NotFound =>
Ok(RpDelete::default()),
Review Comment:
I perfer to use `std::io::ErrorKind::NotFound` here. We can remove the use
`std::io` instead.
##########
core/src/layers/oteltrace.rs:
##########
@@ -308,7 +308,7 @@ impl<R: oio::BlockingRead> oio::BlockingRead for
OtelTraceWrapper<R> {
self.inner.read(buf)
}
- fn seek(&mut self, pos: std::io::SeekFrom) -> Result<u64> {
+ fn seek(&mut self, pos: io::SeekFrom) -> Result<u64> {
Review Comment:
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
