Xuanwo commented on code in PR #2267:
URL:
https://github.com/apache/incubator-opendal/pull/2267#discussion_r1196719569
##########
core/src/services/sftp/backend.rs:
##########
@@ -104,6 +105,7 @@ pub struct SftpBuilder {
user: Option<String>,
key: Option<String>,
known_hosts_strategy: Option<String>,
+ copyable: bool,
Review Comment:
I prefer to use `<verb>_<op>` like `can_copy` or `enable_copy`. In this way,
we don't need to play with english grammer like `movable` (we can't use
`moveable`), `presignable` (there is no such word).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
