This is an automated email from the ASF dual-hosted git repository.
xuanwo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-opendal.git
The following commit(s) were added to refs/heads/main by this push:
new ebfb57b3 fix(core): appender complete check (#2298)
ebfb57b3 is described below
commit ebfb57b33c83ad5a8b44e0843186e37231388d05
Author: Suyan <[email protected]>
AuthorDate: Tue May 23 18:14:27 2023 +0800
fix(core): appender complete check (#2298)
Signed-off-by: suyanhanx <[email protected]>
---
core/src/layers/complete.rs | 2 +-
core/src/services/oss/backend.rs | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/core/src/layers/complete.rs b/core/src/layers/complete.rs
index e4488c6f..0fe80f9b 100644
--- a/core/src/layers/complete.rs
+++ b/core/src/layers/complete.rs
@@ -670,7 +670,7 @@ impl<A> CompleteAppender<A> {
#[cfg(debug_assertions)]
impl<A> Drop for CompleteAppender<A> {
fn drop(&mut self) {
- if self.inner.is_none() {
+ if self.inner.is_some() {
// Do we need to panic here?
log::warn!("appender has not been closed, must be a bug")
}
diff --git a/core/src/services/oss/backend.rs b/core/src/services/oss/backend.rs
index c436fc98..64e78151 100644
--- a/core/src/services/oss/backend.rs
+++ b/core/src/services/oss/backend.rs
@@ -49,6 +49,7 @@ const DEFAULT_WRITE_MIN_SIZE: usize = 8 * 1024 * 1024;
/// - [x] stat
/// - [x] read
/// - [x] write
+/// - [x] append
/// - [x] create_dir
/// - [x] delete
/// - [x] copy