tisonkun commented on PR #2209: URL: https://github.com/apache/incubator-opendal/pull/2209#issuecomment-1560354842
The codebase has been changed a lot with #2276 #2288 #2291. The unwrap boundary is narrowed into three parts now: 1. When `JNIOnLoad` and thread start, I don't think we can handle the exception there. 2. When retrieving the thread local `JNIEnv`. It should be always success otherwise a fatal error. `unwrap` for simplifying the code. 3. When constructing exceptions in async callback - the current thread is a Rust thread, no result can be popped up. Although, for case 3, we can still narrow a bit the error handling part to collect all exceptions before calling `f.completeExceptionally` to an exception to the future, or improving the log. Closing this PR since any meaningful follow-up requires almost rewrite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
