Ji-Xinyou commented on code in PR #2329:
URL:
https://github.com/apache/incubator-opendal/pull/2329#discussion_r1206466709
##########
bindings/c/src/types.rs:
##########
@@ -178,3 +180,63 @@ impl opendal_metadata {
}
}
}
+
+/// [`opendal_operator_options`] represents a series of string type key-value
pairs, it may be used for initialization
+#[repr(transparent)]
+pub struct opendal_operator_options {
+ pub inner: *mut HashMap<String, String>,
Review Comment:
> My point is can we make it private?
I access the keys and values in the `opendal_operator_new()`, so a
pub(crate) will make it easier.
> And can we remove `HashMap_String__String` from our C API?
Then we have to implement our own hashmap or include third-party
dependencies, which is not what we want I think.
If we really really hate the `HashMap_String__String`, we should use the
original solution of `opendal_kv` (maybe another name).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
