Xuanwo commented on code in PR #2431:
URL:
https://github.com/apache/incubator-opendal/pull/2431#discussion_r1224878285
##########
core/src/services/sftp/docs.md:
##########
@@ -18,7 +18,7 @@ This service can be used to:
## Configuration
- `endpoint`: Set the endpoint for connection
-- `root`: Set the work directory for backend, default to `/home/$USER/`
+- `root`: Set the work directory for backend. It uses the default directory
set by the remote `sftp-server` as default
Review Comment:
Please also update the comment for `root()` function.
##########
.github/workflows/service_test_sftp.yml:
##########
@@ -68,3 +77,15 @@ jobs:
OPENDAL_SFTP_USER: foo
OPENDAL_SFTP_KEY: ${{ github.workspace }}/target/ssh/id_rsa
OPENDAL_SFTP_KNOWN_HOSTS_STRATEGY: accept
+ - name: Test (with default root)
Review Comment:
Please add a new job instead so that we can run them concurrently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
