morristai commented on PR #2499: URL: https://github.com/apache/incubator-opendal/pull/2499#issuecomment-1600053452
BTW, same dilemma on whether to use `#[derive(default)]` or `impl Default`. My first implementation used the derive macro, but it required four other sub struct/enum to implement the default macro. Anyway, I've learned a lot from these PR practices. I'll ask for help when I'm stuck again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
