Xuanwo commented on code in PR #2606:
URL:
https://github.com/apache/incubator-opendal/pull/2606#discussion_r1255577277
##########
core/src/services/dropbox/backend.rs:
##########
@@ -162,6 +166,121 @@ impl Accessor for DropboxBackend {
_ => Err(parse_error(resp).await?),
}
}
+
+ async fn batch(&self, args: OpBatch) -> Result<RpBatch> {
Review Comment:
Dropbox's batch delete is not fast, maybe we don't need to implement it?
##########
.github/workflows/service_test_dropbox.yml:
##########
@@ -0,0 +1,66 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Service Test Dropbox
+
+on:
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "core/tests/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/dropbox/**"
+ - ".github/workflows/service_test_dropbox.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ dropbox:
+ runs-on: ubuntu-latest
+ if: github.event_name == 'push' ||
!github.event.pull_request.head.repo.fork
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+
+ - name: Load secret
+ id: op-load-secret
+ uses: 1password/load-secrets-action@v1
+ with:
+ export-env: true
+ env:
+ OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}
+ OPENDAL_DROPBOX_TEST: op://services/dropbox/test
+ OPENDAL_DROPBOX_ROOT: op://services/dropbox/root
+ OPENDAL_DROPBOX_REFRESH_TOKEN: op://services/dropbox/refresh_token
+ OPENDAL_DROPBOX_CLIENT_ID: op://services/dropbox/client_id
+ OPENDAL_DROPBOX_CLIENT_SECRET: op://services/dropbox/client_secret
+
+ - name: Test
+ shell: bash
+ working-directory: core
+ # It's easily for dropbox to trigger too_many_write_operations error.
Review Comment:
We need to retry this error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
