suyanhanx commented on code in PR #2610: URL: https://github.com/apache/incubator-opendal/pull/2610#discussion_r1257467065
########## core/tests/behavior/append.rs: ########## @@ -71,14 +71,16 @@ pub async fn test_append_create_append(op: Operator) -> Result<()> { } /// Test append to a directory path must fail. -pub async fn test_append_with_dir_path(op: Operator) -> Result<()> { +pub async fn test_append_to_dir_path(op: Operator) -> Result<()> { let path = format!("{}/", uuid::Uuid::new_v4()); let (content, _) = gen_bytes(); let res = op.append(&path, content).await; assert!(res.is_err()); assert_eq!(res.unwrap_err().kind(), ErrorKind::IsADirectory); + op.delete(&path).await.expect("delete file must success"); Review Comment: Of course, it's better to do it this way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org