suyanhanx commented on code in PR #2626:
URL:
https://github.com/apache/incubator-opendal/pull/2626#discussion_r1262172149
##########
core/src/services/fs/writer.rs:
##########
@@ -68,7 +68,7 @@ impl oio::Write for FsWriter<tokio::fs::File> {
async fn sink(&mut self, _size: u64, mut s: oio::Streamer) -> Result<()> {
while let Some(bytes) = s.next().await {
let b = bytes?;
- self.f.write_all(&b).await.map_err(parse_io_error)?;
+ self.f.write(b).await.map_err(parse_io_error)?;
}
Review Comment:
We should count the size and update the position.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
