Xuanwo commented on code in PR #2780:
URL:
https://github.com/apache/incubator-opendal/pull/2780#discussion_r1285195845
##########
core/tests/behavior/blocking_list.rs:
##########
@@ -26,10 +26,17 @@ use crate::*;
pub fn behavior_blocking_list_tests(op: &Operator) -> Vec<Trial> {
let cap = op.info().capability();
- if !(cap.read && cap.write && cap.copy && cap.blocking && cap.list) {
+ if !(cap.read && cap.write && cap.copy && cap.list) {
return vec![];
}
+ let mut op = op.clone();
Review Comment:
We should avoid modifying the blocking test suites. Instead, we can make
changes at
https://github.com/apache/incubator-opendal/blob/main/core/tests/behavior/utils.rs#L46.
This approach is more aligned with how OpenDAL users will interact with the
software.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
