ArmandoZ commented on code in PR #2878: URL: https://github.com/apache/incubator-opendal/pull/2878#discussion_r1299209846
########## .env.example: ########## @@ -117,6 +117,10 @@ OPENDAL_WASABI_BUCKET=<bucket> OPENDAL_WASABI_ENDPOINT=<endpoint> OPENDAL_WASABI_ACCESS_KEY_ID=<ak> OPENDAL_WASABI_SECRET_ACCESS_KEY=<sk> +# atomicdata +OPENDAL_ATOMICDATA_TEST=false +OPENDAL_ATOMICDATA_ROOT=/path/to/dir +OPENDAL_ATOMICDATA_ENDPOINT=https://atomicdata.dev Review Comment: I checked again and the current code in PR is only visiting atomicdata.dev to read class/property definitions, and real data is stored locally (this is default behavior of atomic_lib), as you mentioned in the other comment. For example, atomic_lib declares class urls in with atomicdata.dev hardcoded: https://docs.rs/atomic_lib/latest/src/atomic_lib/urls.rs.html#15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
